Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes mech sprites! #83024

Merged
merged 7 commits into from
May 23, 2024
Merged

changes mech sprites! #83024

merged 7 commits into from
May 23, 2024

Conversation

githubuser4141
Copy link
Contributor

@githubuser4141 githubuser4141 commented May 3, 2024

About The Pull Request

removes old mech icons, adds new ones!
the mech icons in question can be viewed via icon diffs bot, I don't have a full scene image of them, yet.
note that mech construction sprites are not done professionally/have been manually edited by me, and not the actual spriter, so results may vary in quality.
Credit to INFRARED_BARON for 100% of the base sprites.

Why It's Good For The Game

Much nicer, chonkier mech icons.
Adds polar hide specific sprites, but lacks the code required to use these, sadly.

image

Changelog

馃啈 by INFRARED_BARON
image: Changes icons of: Gygax, d-gygax, durand, ripley variants, firefighter statue, phazon & odysseus. Adds new icons for polar hide item.
/:cl:

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. Code Improvement Code is now easier to copy paste. labels May 3, 2024
@githubuser4141 githubuser4141 marked this pull request as draft May 3, 2024 14:24
@SyncIt21
Copy link
Contributor

SyncIt21 commented May 3, 2024

Where are the in-game screenshots? Video also is needed for this specific case

@Jacquerel Jacquerel added the Needs Pictures I want to make sure you ran this on your local machine label May 3, 2024
@zxaber
Copy link
Contributor

zxaber commented May 3, 2024

Based and mechpilled.

  • Looks like a few sprites didn't get updated correctly. Phazon's animation, among others.
  • Paddy's siren light overlay needs to be updated to match where the lights are now (and possibly match the new style). I didn't see it in the changes.
  • I can't tell from the icondiff, but Paddy's cockpit is supposed to be open, like the Ripley MK-I.
  • You re-added the Firefighter's sprite, which is based but Fikou might yell at you.

@mc-oofert
Copy link
Contributor

mc-oofert commented May 3, 2024

image
best pic i could find from checks because the rest were having a stroke

but by god does slim ripley and bess not sit well with me

@Exester509
Copy link
Contributor

Yeah, slim ripley really doesn't feel right

@EEASAS
Copy link
Contributor

EEASAS commented May 3, 2024

broken durand sprites are... broken they show up as a rotating gygax

@EEASAS
Copy link
Contributor

EEASAS commented May 3, 2024

actually now that i see, a lot of sprites in mecha.dmi are broken

@Admiral-Gigaton
Copy link

as others have said, slim ripley does look goofy, but if thats the case...

Yeah, slim ripley really doesn't feel right

best pic i could find from checks because the rest were having a stroke

but by god does slim ripley and bess not sit well with me

i present to you... the TGMC Ripley sprite

(side profiles unavailable, not online and I had to scavenge it from their wiki)

image

@githubuser4141
Copy link
Contributor Author

githubuser4141 commented May 3, 2024

image best pic i could find from checks because the rest were having a stroke

but by god does slim ripley and bess not sit well with me

This iconview is bugged for some reason, some of those mechs are probably showing the construction sprites and therefore look a bit bad. Paddy's cage is open, it's a chicken wire mesh that's similar to the hauler mech.

@githubuser4141
Copy link
Contributor Author

as others have said, slim ripley does look goofy, but if thats the case...

Yeah, slim ripley really doesn't feel right

best pic i could find from checks because the rest were having a stroke
but by god does slim ripley and bess not sit well with me

i present to you... the TGMC Ripley sprite

(side profiles unavailable, not online and I had to scavenge it from their wiki)

image

So? I've seen the sprite already, imho it it's too demanding to look at, and if you guys don't like slimripley why didn't you SAY SO on discord when sprites were posted? Wallmations one of the spritetainers that approved
should've showed you, or you should've seen it? And oranges was the one who requested it to be styled after the Aliens power loader which isn't a square brick.

@EricZilla
Copy link
Contributor

You guys know the ripley is meant to be the loader from alien right?
5a74db7952fadc6a85773e4a59947c27

@MaineTheMan
Copy link

the new sprites are nice (definitely needed new ones) but maybe change the ripley a bit, since it isnt forced to only having 2 clamps, so having a mech with visually identifiable clamps on both arms would be weird if you actually have a drill and plasmacutter

@Jackal-boop
Copy link
Contributor

Wonderful. Now we just nerd to add mechs from Lancer.

@githubuser4141
Copy link
Contributor Author

githubuser4141 commented May 10, 2024

Added a screenshot, and support for polar hide attachment.
Not sure if the polar hides work, because they kept breaking when I tested in-game.

@DaCoolBoss
Copy link
Contributor

The non Ripley ones are good, like those a lot. I don't mind the 'thin ripley' but the arms seem a lil off to me, colours on the claws are too high-contrast I think. Paddy's police lights look weird there and I'd prefer them on top of cage. Apart from those they're great.

@AndroidMK2
Copy link

My opinion on the matter is that they look uglier than current ones, even less chonky than originals. Can't say more since it's a objective opinion of mine but you know.

@dawsonkeyes
Copy link
Contributor

Where are the Mauler, Marauder, Seraph, and Reticence? The presence of the Death Ripley means surely those four should be resprited too, especially given the Mauler is an actively used nukeops mech like the Dark Gygax

@Sadboysuss
Copy link
Contributor

Where are the Mauler, Marauder, Seraph, and Reticence? The presence of the Death Ripley means surely those four should be resprited too, especially given the Mauler is an actively used nukeops mech like the Dark Gygax

Probably out of scope, it's already a lot of effort in this pr

@Admiral-Gigaton
Copy link

Where are the Mauler, Marauder, Seraph, and Reticence? The presence of the Death Ripley means surely those four should be resprited too, especially given the Mauler is an actively used nukeops mech like the Dark Gygax

not death ripley, thats paddy, the security ripley mech

@Iamgoofball
Copy link
Contributor

People can cope, the authentic loader ripley is A++ and I love it

@githubuser4141
Copy link
Contributor Author

githubuser4141 commented May 15, 2024

People can cope, the authentic loader ripley is A++ and I love it

Cool, sadly I can't get the armor plate stuff to work on local so I'm assuming it's broken, will just try to ship the sprite changes without code changes.
remove the code improvement label pls.

@githubuser4141 githubuser4141 marked this pull request as ready for review May 15, 2024 21:01
@Ghommie Ghommie added the Good First PR We all have to start somewhere label May 15, 2024
Copy link
Contributor

@Imaginos16 Imaginos16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to double-check that IDB was just having a goof and it wasn't an error with the DMI.

Other than that, excellent work! Baron's always been consistently amazing with his sprites and I'm happy to see his work here.

@githubuser4141 githubuser4141 changed the title changes mech sprites! *WIP* changes mech sprites! May 15, 2024
@githubuser4141
Copy link
Contributor Author

I wonder if it's goobing out because it's expecting frames where there aren't? The new Gygax wreck sprites aren't animated for instance.

@github-actions github-actions bot requested a review from Imaginos16 May 15, 2024 21:49
@Wallemations Wallemations removed the Needs Pictures I want to make sure you ran this on your local machine label May 16, 2024
@KeRSedChaplain
Copy link

my one comment is that I think the durand's visor should be a bit more visible/brighter green, since I always imagined it to be either a glass visor or a singular version of the lights the gygax has

@Livrah
Copy link

Livrah commented May 23, 2024

I think I know why there was no comparison to the old sprites here.

@Nidvex250
Copy link
Contributor

I think I know why there was no comparison to the old sprites here.

probably because they done it already on their discord and we're just downstreamers looking up not bothering to check their discord, lol
It's sprite rework so it'll always be a mixed bag of opinions.
The Ripley mech looking like, well, the exosuit loader that Ripley piloted to beat up a Xeno Queen is A+ though.

@LSommers
Copy link

The... shading? The way the colors are laid out on the sprites is odd, especially compared to other stuff from TG (and no I'm not soulposting, look at current crates/lockers as an example). It's not quite as obvious in the screenshots here, but encountering them ingame is jarring to say the least. There's large swathes of color that just seem to simplified and indistinct- which is a shame because honestly I can get behind powersuit-style RIPLEY, except that it's the worst and most easily spotted offender of this particular visual issue.

The claws. Something about them just looks off, even compared just to the rest of the new mech sprites. Maybe making the claws either a single, solid color, or using a more gradual transition from the brighter to darker metal sections?

github-merge-queue bot pushed a commit to shiptest-ss13/Shiptest that referenced this pull request May 30, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Hello there! Hope you didn't miss me this soon ;)

This PR ports a very recent PR on /tg/, done by the extremely talented
INFRARED_BARON and PR'd by @githubuser4141 (known as wastelandmain on
discord)
- tgstation/tgstation#83024

Since we do have a few original mechs on Shiptest as well, the CLIP
mechs have also been resprited entirely to match the new suits we will
now see in game!


![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/3b03bbc3-a1ba-4403-9e3b-aa9c84c21b35)

![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/1df55795-5f6b-4dfe-a5b7-170eea7b24d4)

### This PR has been ported with the consent of the original PR author,
as well as the original spriter.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
They're a lot prettier than what we currently have, and while we wait
for the fabled mech rework, this is a good enough visual stopgap to not
make me want to tear my eyeballs out.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: INFRARED_BARON, PositiveEntropy
imageadd: Resprites nearly every mech!
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Jun 1, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Hello there! Hope you didn't miss me this soon ;)

This PR ports a very recent PR on /tg/, done by the extremely talented
INFRARED_BARON and PR'd by @githubuser4141 (known as wastelandmain on
discord)
- tgstation/tgstation#83024

Since we do have a few original mechs on Shiptest as well, the CLIP
mechs have also been resprited entirely to match the new suits we will
now see in game!


![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/3b03bbc3-a1ba-4403-9e3b-aa9c84c21b35)

![image](https://github.com/shiptest-ss13/Shiptest/assets/77556824/1df55795-5f6b-4dfe-a5b7-170eea7b24d4)

### This PR has been ported with the consent of the original PR author,
as well as the original spriter.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
They're a lot prettier than what we currently have, and while we wait
for the fabled mech rework, this is a good enough visual stopgap to not
make me want to tear my eyeballs out.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl: INFRARED_BARON, PositiveEntropy
imageadd: Resprites nearly every mech!
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Code is now easier to copy paste. Good First PR We all have to start somewhere Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet