-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Revamping "Ian's Adventure" into a station job trait #82991
Conversation
Finally Ian can become a true adventurer. |
Slow though it may be I have to admit that I still find "twitch plays Ian" more charming than "one guy plays Ian and ignores a bunch of ghosts he has no incentive to listen to". Would this also leave Ian as able to converse in spoken common with random people? That's a side effect that I will say I don't much enjoy about making animal sapient, maybe we should move language granting to the sapience potion instead... |
Those are all good points and overall a major reason why this is still a WIP, except for the ability to speak common, which is something I haven't thought much about but that'd be a nice communication barrier between the ghosts, Ian and the rest of the crew. Good ideas will come with time. |
Okay but Ian being able to hear deadchat, and then trying to act on it but not being understood by the humans, is kinda funny "Whats that Ian? The janitor is trapped in the void?" dog leads the captain to a random heretic rune |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Putting this on hold for a moment. There's a rework on how some mobs, like parrots, mooks and any mob with the "fetch" pet command can carry their items that I have to finish first (so that I can properly give Ian a better hud), and it's cooking slower than I thought. |
About The Pull Request
I remembered making this PR roughly two years ago and having to convince oranges to merge it because he's rightfully a bit skeptical. Moving the dog around thru dchat is tedious. The most fun we've had is slooooowly dragging Ian to the engineering department and have him feed himelf to the SM (as well as a few more folks tried to save a mindless puppy) but not much else... beside doing it twice because of the multiple lives component.
I promised I'd actually improve it later, though between inertia and unwillingness I let two years pass by.
Back to present day: my plan here is to make Ian* player-controllable, while letting ghosts backseat and provide a guidance of some sort.
*or in the unfortunate case he isn't around or something, either Lisa or a random corgi with a random-ass dog name.
Because It's a WIP, here are some things that I still have or would like to do:
Why It's Good For The Game
This is one of those station traits that are at the end quite meager, and could frankly use some extra beef.
Changelog
馃啈
add: Revamped "Ian's Adventure" into a station job trait. Play as Ian (or a backup corgi, if somehow unavailable), or guide him as an observer.
qol: dogs can now consume jumbo dog bone treats on their own.
balance: Only one Lisa (The female counterpart of Ian, from the corgi livestock crate) can exist at a time.
/:cl: