Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit editor QoL and new circuit components #82969

Merged
merged 19 commits into from
May 15, 2024

Conversation

tmyqlfpir
Copy link
Contributor

@tmyqlfpir tmyqlfpir commented Apr 30, 2024

About The Pull Request

This PR introduces a number of minor quality of life improvements to already existing circuit components, and adds three new components.

preview

Why It's Good For The Game

This improves the overall experience for circuits.

UI changes

grid aligned

Grid align is now an option for circuit designers. It will round objects to the nearest 10px units internally, and can be toggled on/off by the new additional button beside the component menu button. This makes circuits easier on the eyes as things are pixel perfect aligned.

tooltips

All three buttons have been given tool tips.

Tweaked Components

voice activator
  • Adds a on/off flag to the voice activator component
    -- This saves power for circuits as you're not forced to use a compare flag check to turn off voice activation
speech
  • Adds a quiet mode flag to speech component
    -- This is ideal when you want a device to speak, but don't want other people to hear. A good example would be a handheld translator that you only want to hear yourself.

New Components

ntnet list literal
  • An NTNet Send component that allows everything to be input much like the list literal component
    -- This makes sending stuff over NTNet easier for the user, and use less power as it won't require an additional list literal component
compare health state
  • A health comparison component that checks the entity's health state, and can return true or false depending if the entity is alive, sleeping, unconscious, critical or dead
    -- This could be achieved by using a health sensor and a compare component, however it lacks the ability to know when a entity is unconscious or sleeping
toggle
  • A quick toggle component to allow the switching between a true and false state
    -- This could be achieved by using a logic component and self linking, however this makes it far easier for newcomers to make something as simple as an on/off switch (such as a handheld translator which uses the front button to turn on/off)

Changelog

🆑
qol: Add tooltips to circuit editor buttons
qol: Add grid alignment mode to circuit editor
add: Added new compare health state component
add: Added new NTNet send list literal component
add: Added new toggle component
qol: Added activity toggle to voice activator component
qol: Added quiet mode to speech component
qol: NTNet send component will not use power/trigger if NTNet is offline
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways UI We make the game less playable, but with round edges Quality of Life Increasing esword damage is not a quality of life for traitors labels Apr 30, 2024
code/modules/research/techweb/all_nodes.dm Outdated Show resolved Hide resolved
code/modules/wiremod/components/bci/user_status.dm Outdated Show resolved Hide resolved
code/modules/wiremod/components/math/toggle.dm Outdated Show resolved Hide resolved
code/modules/wiremod/components/math/toggle.dm Outdated Show resolved Hide resolved
@Watermelon914 Watermelon914 marked this pull request as draft April 30, 2024 11:40
@Watermelon914
Copy link
Member

Make sure to undraft when this is ready to review again, otherwise I'll think you're still working on it.

@tmyqlfpir tmyqlfpir marked this pull request as ready for review May 5, 2024 05:36
Copy link
Member

@Watermelon914 Watermelon914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more things and then this should be ready

@Watermelon914 Watermelon914 marked this pull request as draft May 5, 2024 18:17
@tmyqlfpir tmyqlfpir marked this pull request as ready for review May 6, 2024 00:48
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label May 15, 2024
@Watermelon914 Watermelon914 merged commit 53518e0 into tgstation:master May 15, 2024
20 checks passed
comfyorange added a commit that referenced this pull request May 15, 2024
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-5). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Quality of Life Increasing esword damage is not a quality of life for traitors Stale Even the uncaring universe rejects you, why even go on UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants