-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circuit editor QoL and new circuit components #82969
Conversation
tgui/packages/tgui/interfaces/IntegratedCircuit/ObjectComponent.jsx
Outdated
Show resolved
Hide resolved
Make sure to undraft when this is ready to review again, otherwise I'll think you're still working on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more things and then this should be ready
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Your Fix/Feature pull request is currently below zero (-5). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
About The Pull Request
This PR introduces a number of minor quality of life improvements to already existing circuit components, and adds three new components.
Why It's Good For The Game
This improves the overall experience for circuits.
UI changes
Grid align is now an option for circuit designers. It will round objects to the nearest 10px units internally, and can be toggled on/off by the new additional button beside the component menu button. This makes circuits easier on the eyes as things are pixel perfect aligned.
All three buttons have been given tool tips.
Tweaked Components
-- This saves power for circuits as you're not forced to use a compare flag check to turn off voice activation
-- This is ideal when you want a device to speak, but don't want other people to hear. A good example would be a handheld translator that you only want to hear yourself.
New Components
-- This makes sending stuff over NTNet easier for the user, and use less power as it won't require an additional list literal component
-- This could be achieved by using a health sensor and a compare component, however it lacks the ability to know when a entity is unconscious or sleeping
-- This could be achieved by using a logic component and self linking, however this makes it far easier for newcomers to make something as simple as an on/off switch (such as a handheld translator which uses the front button to turn on/off)
Changelog
🆑
qol: Add tooltips to circuit editor buttons
qol: Add grid alignment mode to circuit editor
add: Added new compare health state component
add: Added new NTNet send list literal component
add: Added new toggle component
qol: Added activity toggle to voice activator component
qol: Added quiet mode to speech component
qol: NTNet send component will not use power/trigger if NTNet is offline
/:cl: