Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a station trait that brightens up IceBox's surface. #82945

Merged
merged 2 commits into from May 3, 2024

Conversation

Ghommie
Copy link
Member

@Ghommie Ghommie commented Apr 28, 2024

About The Pull Request

This PR adds a positive trait that brings lights to the outdoors surface areas of Icebox.

Why It's Good For The Game

Building upon the features of the station traits. This is how it'd look:
It's Always Sunny On IceBoxStation

Changelog

馃啈
add: Adds an Icebox-specific station trait that brightens outdoors areas on the surface level.
/:cl:

@Ghommie Ghommie requested a review from san7890 as a code owner April 28, 2024 23:07
@tgstation-server tgstation-server added the Feature Exposes new bugs in interesting ways label Apr 28, 2024
@Jacquerel
Copy link
Contributor

If only we had the Icebox day/night cycle 馃様

@Ghommie
Copy link
Member Author

Ghommie commented Apr 29, 2024

I don't think it'd fit the vertical underground layout of icebox that well, but a night-day cycle would be pretty easy to make: just have some sort of subsystem or datum entity that gradually changes the base lighting alpha and color of some areas over time.

@Jacquerel
Copy link
Contributor

Oh I thought you would be aware 馃槄
We have unfortunately tried to add this feature on several occasions but never finished.
#74948 #68239

@Ghommie
Copy link
Member Author

Ghommie commented Apr 29, 2024

Oh, those are quite neat. I see why they'd use a lighting object for more natural light transition between outdoors, indoor and underground areas, alas that may be some hot code.

@Iamgoofball
Copy link
Contributor

We should do the day/night cycles; we've got other planetary maps that could benefit from it, including Lavaland itself.

@projectkepler-ru
Copy link
Contributor

This PR is actually cool af.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants