Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes a bunch of unused families huds #82916

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rex9001
Copy link
Contributor

@Rex9001 Rex9001 commented Apr 27, 2024

About The Pull Request

Does what it says on the tin, slices out a bunch of unused antag huds.

Why It's Good For The Game

Its getting pretty annoying to work within that file when half the icons arent used, so this just removes them. The file is less cluttered now.

Changelog

Shouldn't be player facing

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. Removal This was too fun, too fun! I'm turning this feature around labels Apr 27, 2024
@Fikou
Copy link
Member

Fikou commented Apr 27, 2024

theyre useful for admin events

@Rex9001
Copy link
Contributor Author

Rex9001 commented Apr 27, 2024

theyre useful for admin events

I havent seen these used ever, do you want them all to stay?

@Fikou
Copy link
Member

Fikou commented Apr 27, 2024

no this isnt binding i just think theyre useful as generic icons for team antags (admins can create antag teams in game panel and give them these hud icons)

@Iamgoofball
Copy link
Contributor

I'd move 'em off to a different dmi file then.

Copy link
Contributor

github-actions bot commented May 9, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label May 9, 2024
@Rex9001
Copy link
Contributor Author

Rex9001 commented May 10, 2024

I'd move 'em off to a different dmi file then.

Id be fine doing that ig

@github-actions github-actions bot removed the Stale Even the uncaring universe rejects you, why even go on label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal This was too fun, too fun! I'm turning this feature around Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants