Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unhardcodes modsuit parts #82905

Closed
wants to merge 33 commits into from
Closed

unhardcodes modsuit parts #82905

wants to merge 33 commits into from

Conversation

Fikou
Copy link
Member

@Fikou Fikou commented Apr 26, 2024

About The Pull Request

see #70061 but i almost finished it, i only need to go through every single module and assign it a fitting part

Changelog

🆑
refactor: modsuits have been refactored if you see bugs report them
fix: admin cargo tech modsuit outfit now works correctly
/:cl:

@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances Refactor Makes the code harder to read UI We make the game less playable, but with round edges labels Apr 26, 2024
@tralezab
Copy link
Contributor

holy bursh what a pr

@Admiral-Gigaton
Copy link

So if I understand this correctly, judging from the previous PR, you want to make it so the modsuit doesn't have to be a backpack, and can in fact be something else, eg a pair of gloves, or a swag pair of shoes, even your glasses n shit?

If this is right (the other parts are whatever, it's nice that they won't shut down because I lost a toe) then I hope you are changing storage shit (I'm not code diving right now, I'm on mobile) and other such things

Otherwise I absolutely love this and was waiting for the day someone figured out how to do cool shit like this

@Fikou
Copy link
Member Author

Fikou commented Apr 27, 2024

So if I understand this correctly, judging from the previous PR, you want to make it so the modsuit doesn't have to be a backpack, and can in fact be something else, eg a pair of gloves, or a swag pair of shoes, even your glasses n shit?

If this is right (the other parts are whatever, it's nice that they won't shut down because I lost a toe) then I hope you are changing storage shit (I'm not code diving right now, I'm on mobile) and other such things

Otherwise I absolutely love this and was waiting for the day someone figured out how to do cool shit like this

what do you mean by storage shit?

the suit previously supported changing the slot (see infiltrator being on belt), but that was it. every suit still had to use helmet/chestplate/gauntlets/boots. this system allows the suit to be made of anything (like helmet control unit extending glasses and mask for example)
the suit will still disable when losing a limb, changing that will be a separate pr. we just couldnt handle that currently

Copy link
Contributor

github-actions bot commented May 5, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label May 5, 2024
@github-actions github-actions bot closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Refactor Makes the code harder to read Stale Even the uncaring universe rejects you, why even go on UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants