New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starts Shaft Miners equipped with the Kheiral Cuffs. #82885
base: master
Are you sure you want to change the base?
Conversation
Screenshot tests failed! Download zip file of new screenshots. DiffsHelpWhat is this?Screenshot tests make sure that specific icons look the same as they did before. If the produced image looks broken, then it is possible your code caused a bug. I am changing sprites, it's supposed to look different.If the newly produced sprites are correct, then the tests should be updated. You can either:
If you need help, you can ask maintainers either on Discord or on this pull request. This is a false positive.If you are sure your code did not cause this failure, especially if it's inconsistent, Ask maintainers to rerun the test. If you need help, you can ask maintainers either on Discord or on this pull request. |
dangerous, rambunctious and controversial: maybe there is a better way to educate miners about using the kheiral cuffs instead of making them spawn with them on. if we swoop in and pull each player's pants up it lowers the amount of things you need to learn about the game when there is a natural learned advantage to using the kheiral cuffs in the same way there is a natural learned advantage to suit sensors. preround setup is not sacred but at least a little spiritual |
Kheiral Cuffs are not a first purchase. They're, at most, a novelty item and don't really increase your effectiveness while mining, or allow you a greater chance at actually surviving. They only help with body recovery (assuming whatever killed you didn't outright dust you), which relies on someone else going out of their way to recover you. And is being mildly redundant with the availability of a GPS. Just having a GPS on-hand is usually a reasonable equivalency and how most people find miner bodies. That should be what is given to miners at roundstart and something they're encouraged to utilize, because having them is also how you can tell when your fellow miners are potentially dead. The cuffs don't give you this information, so if your fellow miners aren't using GPS units, the cuffs literally do nothing other than annyoing the paramedics who may or may not exist because you're permanently dead on sensors. An actual example of a first purchase is something like the better meds, staiblizers so you can get regen cores (and maybe get them implatned later), or advanced scanners so you can find those vents you probably totally missed. On icebox, a good initial purchase tends to be snow boots as well. The only time I've seen people get the cuffs is for drip (which sometimes gets covered up by some of the suits anyway) |
lavaland is slowly getting un-meatgrindered i'm so happy |
notably, the cuffs are not heatproof, so you won't be able to (for example) remove your ice hiking boots while on fire to prevent them from burning e: that said I do like this change. the difficulty in retrieving a miner's corpse shouldn't be "don't know they're dead". |
I'll be honest, they're more like a possibly 30th purchase if I'm really wanting for things to buy. I lile the black gloves more. And I'll probaly replace it immediately with the crafted bone armguards, special functionality or not. As earlier stated, gps just does it better for anyone observant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would sooner rather we integrate the cuff's primary effect (multi-z suit sensors) into the miner's existing equipment setup, and then sunset them.
Maybe as an implant? Skillchip? Function of the explorer suit? PDA app? Give them a special GPS that does it? I dunno.
This itself relies on us wanting miners to have permanent suit sensors that reach the station, that I don't know if I have an opinion on at the moment. |
Also you didn't even like... adjust the cost of it on the mining order console. (It should be way cheaper if it's a roundstart thing since it's a replacement.) Or put pairs in the mining equipment kit you can order. Cmon man |
Don't miners already have multi-z suit sensors on Icebox? it doesn't suck or seem to cause balance issues there, so I'm inclined to agree
|
i think it's ice box feature, not miners |
Yeah, if someone cares enough to check on miners they'll grab a GPS and look for your signal and wether or not it's moving at all. Granted that doesn't mean they'll go look for your corpse unless they have access to mining gear too to not die pathetically to whatever killed you while recovering you. |
if the cuffs don't get merged, consider putting miner jumpsuits to tracker on roundstart |
I feel like being visibly dead on medical sensors is a BIG deal for whether anyone goes looking for you. Paramedics and AIs hate seeing corpses on their sensor console even if they havent actively thought about miners in half an hour. |
suit sensors should tie into the NTNet Relay system |
perhaps change the cuffs to be a suit attachment type thing as it would be actually augmenting the suit's built in sensors, just a thought |
This seems like a pretty reasonable choice, yeah. |
would be a problem if the suit burnt down after a fight with the drake or falling into lava |
Actually pretty big on this, has an interesting side effect of giving you a chance to have sensors on if your body happens to be on a z level with the radio station. |
I agree with this, it would make suit sensors into a physical thing that exists in the game and can even be turned off. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About The Pull Request
Starts Shaft Miners equipped with the Kheiral Cuffs.
Why It's Good For The Game
In the old mining, the station figured out all the miners were dead because they ran out of mats and they didn't restock. This doesn't occur in new mining, where ore vents and boulders ensure a permanent steady stream of materials for the crew to never think about the miners again.
This results in an extremely unfun experience for new miners who don't know the Kheiral Cuffs should be their first purchase and immediate equip. As such, I've made them spawn on miners by default.
Changelog
🆑
balance: Starts Shaft Miners equipped with the Kheiral Cuffs.
/:cl: