Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blade creation ritual returns lost blades #82592

Merged
merged 13 commits into from
May 15, 2024
Merged

Conversation

Xackii
Copy link
Contributor

@Xackii Xackii commented Apr 11, 2024

About The Pull Request

Blade ritual now break first created blade if limit and create new one. If someone was on a tile with a blade, their hand would be cut off

"updated video"
https://youtu.be/fdMhrW2aoto

Why It's Good For The Game

If heretic loses his blades, then due to the limit on creating new blades, he will not be able to make new blades for himself. Now, you can return your blades.

🆑
balance: Heretic now can return his stolen blades by using blade creation ritual again.
/:cl:

@Admiral-Gigaton
Copy link

neat, glad that you didnt do this via recall spell. that would have been a nightmare, hard enough as it is, even worse if the heretic recalls their blade to their hand after getting batoned and gets the last lick in to crit the secoff

@Xackii
Copy link
Contributor Author

Xackii commented Apr 11, 2024

neat, glad that you didnt do this via recall spell. that would have been a nightmare, hard enough as it is, even worse if the heretic recalls their blade to their hand after getting batoned and gets the last lick in to crit the secoff

maybe this will be done by the ability of one of the heretic paths in the future

@Jacquerel Jacquerel added the Feature Exposes new bugs in interesting ways label Apr 11, 2024
@Rex9001
Copy link
Contributor

Rex9001 commented Apr 11, 2024

I don't really like this, if a heretic loses all of their blades they should've been more careful. As it stands this method is one of few to defang a heretic.

@Xackii
Copy link
Contributor Author

Xackii commented Apr 11, 2024

I don't really like this, if a heretic loses all of their blades they should've been more careful. As it stands this method is one of few to defang a heretic.

this looks like a very broken way, which is more like a flaw. It's like taking away a Ling's arm blade and leaving him with no way to get it back

@Rex9001
Copy link
Contributor

Rex9001 commented Apr 11, 2024

I don't really like this, if a heretic loses all of their blades they should've been more careful. As it stands this method is one of few to defang a heretic.

this looks like a very broken way, which is more like a flaw. It's like taking away a Ling's arm blade and leaving him with no way to get it back

This seems like a very clear and intended flaw of heretic (given the blade limit), I just don't think this is really what heretics need.

@Jacquerel
Copy link
Contributor

I would suggest either making this ritual destroy all existing blades, or combine it with the blade creation ritual (if you're over the cap, destroy the oldest).
Just to avoid people using this to teleport their weapons into perma when they would not usually be able to craft them in there.

@Xackii
Copy link
Contributor Author

Xackii commented Apr 11, 2024

I would suggest either making this ritual destroy all existing blades, or combine it with the blade creation ritual (if you're over the cap, destroy the oldest). Just to avoid people using this to teleport their weapons into perma when they would not usually be able to craft them in there.

sounds better than adding a separate ritual. Although I don’t think that anyone will put a heretic in prison.

@Jacquerel
Copy link
Contributor

Jacquerel commented Apr 11, 2024

sounds better than adding a separate ritual. Although I don’t think that anyone will put a heretic in prison.

Most kinds of Heretic cannot escape from permabrig and it's explicitly expected on one of our servers that people should attempt to detain heretics until they've proven it is impossible (although that's policy not codebase).

@Xackii
Copy link
Contributor Author

Xackii commented Apr 11, 2024

sounds better than adding a separate ritual. Although I don’t think that anyone will put a heretic in prison.

Most kinds of Heretic cannot escape from permabrig and it's explicitly expected on one of our servers that people should attempt to detain heretics until they've proven it is impossible (although that's policy not codebase).

Rast blade can be made in perma, ash, flash (it will hurt a little), void (although unlikely), moon. the knocking path can generally open the doors. It's time to buff Blade and Cosmic(although there may be a chance that plasma will spawn in the perm)

@Sakamoto4ka
Copy link

Imagine put x-4 onto the blades with signaller

@Xackii
Copy link
Contributor Author

Xackii commented Apr 11, 2024

Imagine put x-4 onto the blades with signaller

Oh no

@SimplySmiley123
Copy link

this looks like a very broken way, which is more like a flaw. It's like taking away a Ling's arm blade and leaving him with no way to get it back

This seems like a very clear and intended flaw of heretic (given the blade limit), I just don't think this is really what heretics need.

The blade limit is to prevent the heretics from filling their inventory with just blades to teleport around with no care in the world at any opportunity they get and to force 'em to think when to use it, and a downtime afterwards to make some blades again

If you loose your blades without breaking them, there's nothing you can do and a mere slip can cause you to loose a blade or two. There is no downtime, you just get fucked over for good.

@ATH1909
Copy link
Contributor

ATH1909 commented Apr 12, 2024

imo the best way to fix this is to just remove the blade limit altogether and tie the restriction to the heretic themself instead of how many blades they can carry. make it still require using a blade in-hand, just not shattering one, with the teleport attempt failing if you've used too many blade teleports too recently (something like the emag charge system?)

but this is lowkey bikeshedding on my end, I think

@jughu
Copy link
Contributor

jughu commented Apr 12, 2024

sounds better than adding a separate ritual. Although I don’t think that anyone will put a heretic in prison.

Most kinds of Heretic cannot escape from permabrig and it's explicitly expected on one of our servers that people should attempt to detain heretics until they've proven it is impossible (although that's policy not codebase).

Blade recall should be a ok ritual it shouldnt be a free ritual it should still require items for the ritual.to get your blades back

@Deadgebert
Copy link
Contributor

Deadgebert commented Apr 12, 2024

the ritual should be at least as tedious as the reroll target ritual. don't lose your blades.

it's very difficult to stop a decent heretic, even with constant pressure from a fully staffed security team. They will blade break at any sign of telebaton or single hit from stun baton. punishing mistakes is extremely important to catching them.

holding any number of blades is also an incentive for security to catch and release.

heretic is an extremely strong antag, I don't think they even need this.

also. will this recall blade + backpack it is being held in like gar'yok does, or just the blade?

@Xackii
Copy link
Contributor Author

Xackii commented Apr 12, 2024

the ritual should be at least as tedious as the reroll target ritual. don't lose your blades.

it's very difficult to stop a decent heretic, even with constant pressure from a fully staffed security team. They will blade break at any sign of telebaton or single hit from stun baton. punishing mistakes is extremely important to catching them.

holding any number of blades is also an incentive for security to catch and release.

heretic is an extremely strong antag, I don't think they even need this.

also. will this recall blade + backpack it is being held in like gar'yok does, or just the blade?

only the blade returns. The heretic is a weak antagonist. While he is so worried about his two blades, the cultists can make themselves 15 swords and 20 teleporters, and if they lose them, they can easily go and make more. Without blades, the heretic turns into a weak version of a cultist + a weak version of a wizard(if, of course, he managed to learn at least some spells). everyone says that the heretic is strong just because he can avoid battle by breaking his blade? This is a very strange claim. Almost all antagonists have a way to escape from the battle, but for a heretic, breaking a blade is a very big problem because you need to spend a lot of time to make a new one (when the secs are chasing you, you won’t have this time), and if the heretic is left without blades and without opportunity to return them, you can completely forget about victory.

@mc-oofert
Copy link
Contributor

Personally I think a better idea would be to make the blade creation ritual destroy the oldest blade if at limit

@Dorsisdwarf
Copy link
Contributor

Dorsisdwarf commented Apr 12, 2024

only the blade returns. The heretic is a weak antagonist. While he is so worried about his two blades, the cultists can make themselves 15 swords and 20 teleporters, and if they lose them, they can easily go and make more. Without blades, the heretic turns into a weak version of a cultist + a weak version of a wizard(if, of course, he managed to learn at least some spells).

(Well, the heretic is a very common multi-spawn low-threat antag who builds strength over the course of a round while the cult are a roundending group antag superthreat who establish fortified hidden bases to do their construction in (And may need to keep supplying new converts) and the Wizard is a primary antag expected to play loud and violent against the entire crew, so it makes sense that their situations are very different)

However, they definitely need some recourse to "oops blades vanished into someones bag forever by mistake, you can no longer play the antag" because antags being able to get accidentally neutered like that is a bit sad and shouldnt really be considered a "balancing" factor, since it seems unintentional. I definitely prefer "ritual destroys lost blades" to "ritual summons your blades" though because the more uncontainable heretics become, the more justified security become to kill 'em on sight.

@MrMelbert
Copy link
Contributor

this looks like a very broken way, which is more like a flaw. It's like taking away a Ling's arm blade and leaving him with no way to get it back

This seems like a very clear and intended flaw of heretic (given the blade limit), I just don't think this is really what heretics need.

Rex is correct this is an intended flaw

@Xackii Xackii changed the title Heretic: add a new starting ritual: "Blade Recall" Heretic now can return his losten blades when using blade creation ritual Apr 12, 2024
@Xackii
Copy link
Contributor Author

Xackii commented Apr 12, 2024

this looks like a very broken way, which is more like a flaw. It's like taking away a Ling's arm blade and leaving him with no way to get it back

This seems like a very clear and intended flaw of heretic (given the blade limit), I just don't think this is really what heretics need.

Rex is correct this is an intended flaw

looks very strange

@Xackii
Copy link
Contributor Author

Xackii commented Apr 12, 2024

Did everything in one blade creation ritual

@Xackii Xackii requested a review from Ghommie May 5, 2024 05:18
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label May 13, 2024
@jlsnow301 jlsnow301 changed the title Heretic now can return his losten blades when using blade creation ritual Blade creation ritual returns lost blades May 13, 2024
@jlsnow301
Copy link
Contributor

i wouldve losten my mind if i read that again

@github-actions github-actions bot removed the Stale Even the uncaring universe rejects you, why even go on label May 14, 2024
@Ghommie
Copy link
Member

Ghommie commented May 14, 2024

Ok, the feedback message is still a bit quirky and doesn't sound alarming enough for something that'd rip an arm off, and the fact it doesn't take into account whether the person has or doesn't have a left arm, or why it'd always target the left arm, even if wielded on the right hand or, who knows, slotted in a backpack or holstered on the belt or suit carry slot leaves me in a slight state of eldritch bewilderment...

...but I'm willing to merge it soon and see how it plays out, unless someone else says otherwise. The PR has been open for a long while now but I ran into a few inconveniences last week so I couldn't be around.

@Ghommie Ghommie merged commit 737f571 into tgstation:master May 15, 2024
20 checks passed
github-actions bot added a commit that referenced this pull request May 15, 2024
@Dawnseer
Copy link
Contributor

Oh no

MrMelbert added a commit that referenced this pull request May 31, 2024
optimumtact pushed a commit that referenced this pull request Jun 2, 2024
Reverts #82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:
SkyratBot pushed a commit to Skyrat-SS13/Skyrat-tg that referenced this pull request Jun 2, 2024
Reverts tgstation/tgstation#82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:
NovaBot13 pushed a commit to NovaSector/NovaSector that referenced this pull request Jun 2, 2024
Reverts tgstation/tgstation#82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:
Useroth pushed a commit to Skyrat-SS13/Skyrat-tg that referenced this pull request Jun 3, 2024
* Revert "Blade creation ritual returns lost blades" (#83594)

Reverts tgstation/tgstation#82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:

* Revert "Blade creation ritual returns lost blades"

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
vinylspiders pushed a commit to NovaSector/NovaSector that referenced this pull request Jun 3, 2024
* Revert "Blade creation ritual returns lost blades" (#83594)

Reverts tgstation/tgstation#82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:

* Revert "Blade creation ritual returns lost blades"

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: NovaBot13 <novasector13@gmail.com>
Iajret pushed a commit to Fluffy-Frontier/FluffySTG that referenced this pull request Jun 3, 2024
* Revert "Blade creation ritual returns lost blades" (#83594)

Reverts tgstation/tgstation#82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:

* Revert "Blade creation ritual returns lost blades"

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: NovaBot13 <novasector13@gmail.com>
ArkStation-Bot pushed a commit to ArkStation13/Ark-Station-13 that referenced this pull request Jun 3, 2024
* Revert "Blade creation ritual returns lost blades" (#83594)

Reverts tgstation/tgstation#82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:

* Revert "Blade creation ritual returns lost blades"

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: NovaBot13 <novasector13@gmail.com>
SmthAwfl pushed a commit to ArkStation13/Ark-Station-13 that referenced this pull request Jun 3, 2024
…242)

* [MIRROR] Revert "Blade creation ritual returns lost blades" (#2808)

* Revert "Blade creation ritual returns lost blades" (#83594)

Reverts tgstation/tgstation#82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:

* Revert "Blade creation ritual returns lost blades"

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: NovaBot13 <novasector13@gmail.com>

* [MIRROR] Revert Blade

---------

Co-authored-by: NovaBot <154629622+NovaBot13@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: NovaBot13 <novasector13@gmail.com>
Iajret pushed a commit to Fluffy-Frontier/FluffySTG that referenced this pull request Jun 3, 2024
* Revert "Blade creation ritual returns lost blades" (#83594)

Reverts tgstation/tgstation#82592

The point of the limit on blades is to punish heretics for handling them
carelessly, allowing them to undo that for free is lame.

Maybe someone can re-add this as a separate ritual which has its own
requirements, maybe a knowledge requirement.

🆑
del: Heretics can no longer return their stolen blades, that's the point
of the limit
/:cl:

* Revert "Blade creation ritual returns lost blades"

---------

Co-authored-by: NovaBot <154629622+NovaBot13@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: NovaBot13 <novasector13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet