Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes evo fade in for xenos #15842

Merged
merged 4 commits into from May 19, 2024
Merged

Removes evo fade in for xenos #15842

merged 4 commits into from May 19, 2024

Conversation

yyzsong
Copy link
Contributor

@yyzsong yyzsong commented May 10, 2024

About The Pull Request

This feature doesn't really do anything but mildly annoy the xeno for 2 seconds upon spawning or evolving. I'm tired of being mildly annoyed.

in gh#14149 the fade in was advertised as both a way to remove xeno hitlag and as an immersion thing. The xeno hitlag was proved to be false, but it was merged because of the immersion thing. I don't think the immersion thing is worth it, hence the removal

Why It's Good For The Game

All minor inconveniences must be destroyed. Immersion isn't real

Changelog

馃啈
del: Xenos evolution fade-in effect removed
/:cl:

@tgstation-server tgstation-server added the Removal Feature removal due to maintainibility or design direction. label May 10, 2024
@Lumipharon
Copy link
Contributor

the on evo one apparently proved pointless (and is annoying) but the spawn in one should stay imo

@yyzsong
Copy link
Contributor Author

yyzsong commented May 10, 2024

the on evo one apparently proved pointless (and is annoying) but the spawn in one should stay imo

spawn in one is iffy anyways given that (IIRC) it only happens when you join via lobby and not when you spawn via observer xeno spawn

it's inconsistent and still annoys me. I don't think anyone will miss it

@Wisemonster
Copy link
Contributor

Wisemonster commented May 10, 2024

I thought this was added to reduce on-hit stutter on older PCs?
Edit: Just read the pr, if it's not doing anything to reduce it, I won't really miss it

@ivanmixo
Copy link
Contributor

ivanmixo commented May 10, 2024

Adding yet another overlay to load would do the exact opposite (even if extremely, extremely minor)

@TiviPlus
Copy link
Member

the on evo one apparently proved pointless (and is annoying) but the spawn in one should stay imo

Agree

@TiviPlus
Copy link
Member

Adding yet another overlay to load would do the exact opposite (even if extremely, extremely minor)

People are spreading a rumor that it fixes things to preload an overlay (as I said 5000 times it does not)

@yyzsong yyzsong changed the title Removes spawn in and evo fade in for xenos Removes evo fade in for xenos May 18, 2024
@Lumipharon Lumipharon merged commit 4815d16 into tgstation:master May 19, 2024
34 checks passed
github-actions bot added a commit that referenced this pull request May 19, 2024
@yyzsong yyzsong deleted the fade-away branch May 19, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal Feature removal due to maintainibility or design direction.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants