Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lava and fire jumping #15832

Merged
merged 1 commit into from May 21, 2024
Merged

Lava and fire jumping #15832

merged 1 commit into from May 21, 2024

Conversation

blackdav123
Copy link
Contributor

@blackdav123 blackdav123 commented May 10, 2024

About The Pull Request

Lava and fire will now not deal damage when jumped over, previously not igniting but still dealing the damage.

Why It's Good For The Game

Jumping over fire shouldnt still apply half of the effects.

Changelog

馃啈
balance: Lava and fire no longer deal damage when jumped over.
/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label May 10, 2024
@Lumipharon
Copy link
Contributor

Lumipharon commented May 10, 2024

this is explicitly designed behavior. I'm not closing the pr (although I prefer it this way), but this is a balance change, not a fix.

@QualityVan QualityVan added Balance Changes to functionality that modifies how effective certain methods are at powergaming. and removed Fix Fixes an issue with the game. labels May 10, 2024
@QualityVan QualityVan changed the title Lava and fire fix Lava and fire jumping May 10, 2024
@TiviPlus
Copy link
Member

Can u say why though

@ivanmixo
Copy link
Contributor

Is this really intended? Think it's kinda silly to only apply some of the effects, are there really balance ramifications for you not taking the tiny bit of burn damage when crossing a fire tile?

@Lumipharon
Copy link
Contributor

If you want to merge it thats fine, I was just pointing out I deliberately made it that way, so jumping wouldn't make you entirely immune to negative effect of passing directly over boiling rock.

@Breadeagle
Copy link

does this effect throws over lava and fire tiles?

@blackdav123
Copy link
Contributor Author

does this effect throws over lava and fire tiles?

unless you are jumping while a crusher or something flings you no, it still deals damage for every tile you cross

@Lumipharon Lumipharon merged commit 27d8360 into tgstation:master May 21, 2024
34 checks passed
github-actions bot added a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants