Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a vehicle spawner to xeno valhalla #15830

Merged
merged 1 commit into from May 20, 2024

Conversation

Wisemonster
Copy link
Contributor

@Wisemonster Wisemonster commented May 9, 2024

About The Pull Request

Adds a vehicle spawning area to xeno valhalla. Also adds the associated button and landmark for spawning vehicles (currently apc and tank)
tgmc  _maps_map_files_generic_Admin_Level dmm  - StrongDMM 5_9_2024 12_59_39 PM

Why It's Good For The Game

Let's xenos test their abilities on vehicles safely within valhalla.

Changelog

馃啈
add: Added a vehicle spawning area to xeno valhalla
add: Added a vehicle spawner and vehicle spawner landmark (Things used for spawning in Valhalla)
/:cl:

@tgstation-server tgstation-server added Map Edit One or more changes to .dmm files. Feature New interesting mechanics with new interesting bugs labels May 9, 2024
@Wisemonster
Copy link
Contributor Author

Note, I didn't add the vehicle button to marine Valhalla cause I didn't know how qdell_null affected mobs inside of a vehicle.

@MLGTASTICa
Copy link
Contributor

if interior doens't matter for xeno valhalla then why not make a subtype without one ? code is all compatible.

@Wisemonster
Copy link
Contributor Author

It doesn't really affect anything, considering the interior is deleted when the apc is, and if there ever is a caste that can enter the apc, that should be testable in valhalla.

@TiviPlus
Copy link
Member

Note, I didn't add the vehicle button to marine Valhalla cause I didn't know how qdell_null affected mobs inside of a vehicle.

it force ejects them iirc

Copy link
Member

@TiviPlus TiviPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actualy just checking i see where = xenocave and link = vehiclexenocave, is that correct

@Wisemonster
Copy link
Contributor Author

Yes, because I was only adding the 1, so I figured not having it be named "xenocaveleft" would be fine

@TiviPlus TiviPlus merged commit 58422c7 into tgstation:master May 20, 2024
34 checks passed
github-actions bot added a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Map Edit One or more changes to .dmm files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants