Attrition fix #15820
Merged
Attrition fix #15820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiviPlus
requested changes
May 10, 2024
code/datums/gamemodes/campaign.dm
Outdated
Comment on lines
327
to
328
| to_chat(usr, "<span class='warning'>Unable to spawn. Insufficient attrition.<spawn>") | ||
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes a bug with attrition, where it only checks attrition when you first open the spawn window. So if multiple people open it at the same time (most commonly when rapid reserves is used), more people could spawn than you had attrition for.
This led to negative attrition in some cases, and is also what would break ally spawns (as even though they have zero attrition cost, once you're in the negatives, you're below that cost)
Why It's Good For The Game
bug fix.
Changelog
馃啈
fix: Campaign: Fixed an issue with attrition going into the negatives, allowing for more respawns than intended, and breaking allied spawns
/:cl: