Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Goon's Life For Me #15811

Closed
wants to merge 12 commits into from
Closed

A Goon's Life For Me #15811

wants to merge 12 commits into from

Conversation

tyeagg
Copy link
Contributor

@tyeagg tyeagg commented May 6, 2024

About The Pull Request

PLEASE READ https://hackmd.io/@wlLEbadtQoCyE4iytTkonw/HymHjCLf0

per request of art directors
A push towards proper art direction
Removal of:

  • mk1 jaeger
  • style line armor
  • xenonauten
  • crasher armor
  • uniform variations
  • colorable gloves
  • majority of capes with exception of short, and scarves
  • armor coloring with exception of secondary colors located on arm plates, leg plates, and visors

image

Why It's Good For The Game

Create uniformity and a sense of cohesion in the art style, things have been taken too far and its time to take a step back

Changelog

🆑
del: limited armor coloring
del: colorable uniforms
del: colorable gloves
del: orion,big red, lv, turtlenecks, black suit, jaeger undersuit uniforms
del: crasher armor
del: xenonauten
del: jaeger mk1
del: style line armor
imageadd: uncolorable elements to armor
imagedel: several capes with exception of scarf and short
/:cl:

@tgstation-server tgstation-server added Sprites Changes to .dmi file. Merge Conflict Pull request is in a conflicted state with base branch. Map Edit One or more changes to .dmm files. labels May 6, 2024
@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label May 6, 2024
@novaepee
Copy link
Contributor

novaepee commented May 6, 2024

image

@BonkaiB
Copy link

BonkaiB commented May 6, 2024

Uniformity i feel isn't a valid argument here as people don't come here for such. I feel this should extend to things that aren't maintained and or aren't maintainable. Cohesion should be something encouraged rather than forced ontop people and frankly isn't impossible even now to achieve it. it's just not your version of your idea of cohesion. We're not CM, nor does the majority of people here want it to be akin to CM's uniformity or cohesion

The only points here i see as valid are mk1 jeager and a good portion of capes (not all of them). The extremes of it should be cropped out but literally not 75% of the armor choices and conveniently the armors i see the least used (diet cola syndicate, Clone armor (?) if its still in and the power rangers armor) unless this is included in style line, are missing from this if you're truly trying to go after extremes of it

@Wisemonster
Copy link
Contributor

I can understand things like reducing the style lines and variety of capes, considering I've been able to use capes and style line jackets to make my character look like an egg/chicken, but stripping out so much without adding anything in it's place is gonna just make marines look like a Halo Reach match. Not to mention the little parts left in for customization (a cape/scarf, helmet cosmetics, masks) are in short supply, or just not visible on the jaeger helmets (in the case of masks). Will there even be a way to look like a generic marine anymore? Overall, unless there's a follow-up pr adding some kind of customization, I really don't think this is a good pr as it's currently planned.

@tgstation tgstation locked as too heated and limited conversation to collaborators May 7, 2024
@tgstation tgstation deleted a comment from ZAMODA May 7, 2024
@tgstation tgstation deleted a comment from Yttriums May 7, 2024
@tgstation tgstation deleted a comment from Fawcksy May 7, 2024
@tgstation tgstation deleted a comment from Isy232 May 7, 2024
@tgstation tgstation deleted a comment from gpinrgrmoma May 7, 2024
@tgstation tgstation deleted a comment from Aroliacue May 7, 2024
@tgstation tgstation deleted a comment from SimplySmiley123 May 7, 2024
@tgstation tgstation deleted a comment from Alexeivichi May 7, 2024
@tgstation tgstation deleted a comment from Araulius May 7, 2024
@tgstation tgstation deleted a comment from Looking4bros May 7, 2024
@tgstation tgstation deleted a comment from aarrisu May 7, 2024
@tgstation tgstation deleted a comment from gpinrgrmoma May 7, 2024
@tgstation tgstation deleted a comment from Ispartanli May 7, 2024
@tgstation tgstation deleted a comment from SimplySmiley123 May 7, 2024
@tgstation tgstation deleted a comment from chizzy376 May 7, 2024
@tgstation tgstation deleted a comment from CoastalCookie May 7, 2024
@Kuro020
Copy link
Member

Kuro020 commented May 8, 2024

Another factor is that there is no guarantee that because this pr is merged, that Jaeger MK. III will be made and merged. This was the reason the tad wasn't nerfed till after vehicles was made and merged, cause until the follow-up pr is made, it will be a "maybe this will replace it eventually". And if that pr isn't made, then what we are left with is a pr stripping out a lot of cosmetics in anticipation for a pr that will never come.

Already in talks with tivi and MK3 is being made, idk if we'll even need this pr, I'm leaving it up to annoy everyone have insurance

Honestly? I’d be much more fine with this if it was a gradual thing, with mk3 equivalents being added over time instead of everything being nuked at once, as I believe this would be better for spriters and players alike, so I truly do hope you go through with not adding this PR directly.

I need to set expectations for what it actually does:

image

@Kuro020
Copy link
Member

Kuro020 commented May 8, 2024

and the hackmd above says how it works, thats what people should be expecting

@MiniMeatwad
Copy link
Contributor

firefox_sMy2X5DLgS

@EEASAS
Copy link

EEASAS commented May 8, 2024

the comments were unlocked, so i'll state this

i dont entirely give a fuck

@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label May 9, 2024
@CVSthePharmacy
Copy link

removing a bunch of clothings is not at all what the community wants, the ratio on this pr is proof, I feel like no actual feedback from the COMMUNITY was taken. Close this PR

@Tailiik
Copy link

Tailiik commented May 9, 2024

Let him cook

@XElectricX
Copy link
Contributor

Do this PR AFTER the Mk3 armor stuff is made, not before. Like someone mentioned with Tad not being nerfed until APCs were a thing.

@gpinrgrmoma
Copy link

gpinrgrmoma commented May 10, 2024

Do this PR AFTER the Mk3 armor stuff is made, not before. Like someone mentioned with Tad not being nerfed until APCs were a thing.

This PR is literally just a politica nuclear optionl move to get coders to do a thing

(they did not tell the coder what they want, lol, lmao)
image

@Kuro020
Copy link
Member

Kuro020 commented May 11, 2024

removing a bunch of clothings is not at all what the community wants, the ratio on this pr is proof, I feel like no actual feedback from the COMMUNITY was taken. Close this PR

cute

@gpinrgrmoma
Copy link

gpinrgrmoma commented May 11, 2024

removing a bunch of clothings is not at all what the community wants, the ratio on this pr is proof, I feel like no actual feedback from the COMMUNITY was taken. Close this PR

yeah lol Kuro doesn't really care what the community actually wants

@FosterGrime-Heymynameslouie
Copy link
Contributor

I kinda agree with the points except for jeager being choosen
itd be alot cooler if xenonatuean was the standard instead of jeager
jeager and halo armor as cool as it is, is kinda boring and generic

while xenonatean compared to jeager has way more personality and more variety and is kinda ingrained in tgmc culture by now

like cmon, generic sci fi halo armor vs a dude with a body armor, muscles exposed and a whole lot of determination is a match up where I know where my money is going

also really like how different modules actively change how they look, instead of just having a simon says circle toy in the back change colors

@CoastalCookie
Copy link

CoastalCookie commented May 15, 2024

I kinda agree with the points except for jeager being choosen itd be alot cooler if xenonatuean was the standard instead of jeager jeager and halo armor as cool as it is, is kinda boring and generic

while xenonauten compared to jeager has way more personality and more variety and is kinda ingrained in tgmc culture by now

like cmon, generic sci fi halo armor vs a dude with a body armor, muscles exposed and a whole lot of determination is a match up where I know where my money is going

also really like how different modules actively change how they look, instead of just having a simon says circle toy in the back change colors

Xenonauten has less fashion wise is less used and the modules change the looks on jeager too...

Also the fantasy that all the marines are ripped is a dream you must dream on... We can barely hold onto a rifle while falling let alone walk while aiming, we need a rope around our hand to carry our pistols and need to tighten the strap if we want to hold onto our claymores/shields

But jokes aside

Jaeger has most if not more options to look like a normal marine then xenonauten you can have setups which show your arms off if you really wish
After all xenonauten is literally just cm armor but made into 3 tiers of L.M.H (light medium heavy)

While i could mope about the pr deleting everything i love about tgmc its too funny at this point to even care

@AndroidMK2
Copy link

AndroidMK2 commented May 15, 2024

I hope this never gets merged, simple as. This whole thing looks to me as if a few coders/autistics decided to snap out majority of customisation from players just because they feel like it despite majority of the player base being against it. This ain't your personal game pal, you're just autistic enough to know how to add code to it so maybe consider what others actually want to keep before thanos snapping the entirety of armor customisation.

@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label May 15, 2024
@ilikesaying
Copy link

Robot Armour Mk2 when

@CVSthePharmacy
Copy link

I hope this never gets merged, simple as. This whole thing looks to me as if a few coders/autistics decided to snap out majority of customisation from players just because they feel like it despite majority of the player base being against it. This ain't your personal game pal, you're just autistic enough to know how to add code to it so maybe consider what others actually want to keep before thanos snapping the entirety of armor customisation.

I honestly hope kuro gets removed, we need an actual head coder who listens to the community

@FountainOfNil
Copy link

hey buddy
people don't like this, nor do they like you when you write "cute" to dismiss them
this is the type of stuff that kills servers in the span of a couple of years or so
how about, instead of deleting things, you modify it to make it look better and more inline with what you wanted as a compromise

@FosterGrime-Heymynameslouie
Copy link
Contributor

I kinda agree with the points except for jeager being choosen itd be alot cooler if xenonatuean was the standard instead of jeager jeager and halo armor as cool as it is, is kinda boring and generic

while xenonatean compared to jeager has way more personality and more variety and is kinda ingrained in tgmc culture by now

like cmon, generic sci fi halo armor vs a dude with a body armor, muscles exposed and a whole lot of determination is a match up where I know where my money is going

also really like how different modules actively change how they look, instead of just having a simon says circle toy in the back change colors

image

I conceced my statement, I havent played like in 4 months and didnt know jaeger also changes depending on modules

@DrAmazing343
Copy link

As long as the ODST helmet remains in the game, I can LARP in peace. I do certainly hope some of the cape/mantles stay in, at least the variants that just hang around the neck rather than going all the way down; the shredded variants especially cut off around the waist so it doesn't significantly cover it all and looks cool as hell as an accessory.

@Iamgoofball

This comment was marked as off-topic.

@Iamgoofball

This comment was marked as off-topic.

@tgstation tgstation deleted a comment from MrStonedOne May 25, 2024
@tgstation tgstation locked as off-topic and limited conversation to collaborators May 25, 2024
@spookydonut
Copy link
Contributor

Please read: https://hackmd.io/@wlLEbadtQoCyE4iytTkonw/HymHjCLf0

This PR is unlikely to be merged, or at least not until after or as part of the introduction of the replacement armor

@spookydonut
Copy link
Contributor

Per discussion with kuro this PR is no longer needed, please read the hackmd documented linked if you are unclear on what is happening with changes to armor: https://hackmd.io/@wlLEbadtQoCyE4iytTkonw/HymHjCLf0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Do Not Merge Pull request should not be merged due to design conflict or being a temporary change. Do Not TM Current state of the PR would impair the game if tested. Map Edit One or more changes to .dmm files. Merge Conflict Pull request is in a conflicted state with base branch. Sprites Changes to .dmi file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet