Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-op on mobile / prohibitively small screens #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wTheRockb
Copy link

@wTheRockb wTheRockb commented Apr 19, 2022

Could consider not showing the graph while on mobile. Becase there are so many nodes, the d3 simulation takes a long time to settle with limited processing power (~40s on my pixel 5A). Additionally since there is no hover on mobile, user can't preview article title of the node, making it essentially a link to a random article.

After (fewer posts shown since I deleted a bunch to speed up build times while developing):
127 0 0 1_8000_

@wTheRockb wTheRockb closed this Apr 19, 2022
@wTheRockb wTheRockb deleted the no-graph-mobile branch April 19, 2022 04:26
@wTheRockb wTheRockb restored the no-graph-mobile branch April 19, 2022 04:26
@wTheRockb wTheRockb reopened this Apr 19, 2022
@tgig
Copy link
Owner

tgig commented Apr 20, 2022

Thanks @wTheRockb, you may be right, but damn I like the exploding nodes! I'm going to leave this open for now to ponder what kind of experience I want on mobile - fast or cool, or something else? (looking forward to our call tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants