This repository has been archived by the owner on Jan 2, 2018. It is now read-only.
Image cropper #214
Open
Image cropper #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- WYSIWYG background selector - different backgrounds for landscape and portrait modes
- added support portrait and landscape backgrounds - background image anchored on top only, no resizing with opened keyboard
- inPortrait have bug when keyboard opened, wrong state returned
|
I just don't like changing setGroupPicture(string jid, string file); to setGroupPicture(string jid) Any pre-processing for pictures shouldn't have affected these methods. same for setMyProfilePicture |
|
i just didnt wanted to produce so many parameters for each function. but i can send all parametersm, using by transformPicture thru setXXXPicture function, if need |
|
I guess you are right, I think it might be too much to send it to each picture-related function. Maybe there is a better way. Let me check, I'll take care of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented image cropper for profile picture, group picture and background selectors.
initial InteractionArea.qml implementation by @knobtviker