Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django filter typing improvements #661

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Conversation

tfranzel
Copy link
Owner

continuation of carltongibson/django-filter#1479

@jeking3 would you mind reviewing this? specifically the impact on your schema

  • now allowing extend_schema_field decoration of filter methods (in addition to wrapping the field itself)
  • also raise priority (but lower than decoration) of type hints on filter methods since it is a deliberate attempt to provide more information. before, most hints to value were simply not considered.

fyi users of this extension, feedback welcome: @johnthagen @markopy @valentijnscholten @elonzh @mblayman

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #661 (6f1de26) into master (5da99c5) will increase coverage by 0.09%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
+ Coverage   98.80%   98.90%   +0.09%     
==========================================
  Files          63       63              
  Lines        7024     7025       +1     
==========================================
+ Hits         6940     6948       +8     
+ Misses         84       77       -7     
Impacted Files Coverage Δ
drf_spectacular/contrib/django_filters.py 92.30% <92.00%> (+6.45%) ⬆️
tests/contrib/test_django_filters.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da99c5...6f1de26. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants