docs: add sveltekit update and alt config #1162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I struggled setting this up with sveltekit, and was only able to get it working with the added `mergeConfig`
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Comment on lines
+78
to
+80
| Previously `vitest-svelte-kit` could be used, but it is not necessary anymore and depreceated since `svelte-kit` is now a vite plugin. | ||
|
|
||
| If you struggle getting this working with the above vitest configuration, use the `mergeConfig` instead in `vitest.config.ts`: |
There was a problem hiding this comment.
Could we reword this in a sentence that explains how to use mergeConfig?
Imho, mentioning vitest-svelte-kit is not important because it's deprecated, and it isn't needed.
Thoughts?
There was a problem hiding this comment.
Hey @MentalGear what do you think of this suggestion?
There was a problem hiding this comment.
Would you then like to update this PR with the proposed changes? 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled setting this up with sveltekit, and was only able to get it working with the added
mergeConfig