Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support zh-Hans #1158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support zh-Hans #1158

wants to merge 1 commit into from

Conversation

xupea
Copy link

@xupea xupea commented Oct 18, 2022

Two major changes:

  1. support i18n
  2. support zh-Hans(简体中文)
  3. up-to-date: 2023-03-10

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 5055c9b
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/640a11efd642be000828c19b
😎 Deploy Preview https://deploy-preview-1158--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MatanBobi
Copy link
Member

Hi @xupea!
Thanks for working on this.
It might take me some time to review this one but I'll put it on my list :)

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we review this, I would like to hear more opinions if we should add more languages to the docs or not.
Because this will also have an impact (read take time) in the future.

If the majority approves, some "ground rules" would be useful to add to the contributing guidelines.

@MatanBobi
Copy link
Member

I believe translations is a good idea and 100% agree that we should add ground rules for the contribution guidelines and talk about it a bit before merging :)

@alexkrolick
Copy link
Collaborator

Docusaurus has good i18n support. Although it's likely there will be some divergence in the docs for different languages, it seems like a good thing to do. It would be nice to have a "translation lead" for each language that stays subscribed to this repo and tries to keep up with changes to the docs as the APIs change. Community contributions also welcome.

@nazarepiedady
Copy link

@MatanBobi @alexkrolick

What happened to the translation initiative for the project?

I think this will increase the usage and access of the
non-native English speakers and programmers
to the current project.

@MatanBobi
Copy link
Member

@nazarepiedady I didn't get the chance to review this one. I'll do my best to get to it soon :)

@nazarepiedady
Copy link

@MatanBobi we need this feature as soon as possible,
because this will increase the number of its users, mainly
those that are non-English natives.

@nickmccurdy
Copy link
Member

Do we need to move English into i18n too?

@nazarepiedady
Copy link

@nickmccurdy accordingly to the preview of the website, it seems to
work well without it, but to keep consistency in the project and also to
ease the understanding of the codebase I believe it is better to move
the English version to i18h too if it is possible to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants