Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move @types/react-dom to optional peer dependencies #1305

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Move @types/react-dom to optional peer dependencies #1305

wants to merge 2 commits into from

Commits on Apr 26, 2024

  1. feat: Move @types/react-dom to peer dependencies 

    Type dependencies need to match their runtime counterpart.
If `foo` is a dependency, `@types/foo` needs to be one as well.
If `foo` is a peer dependency, `@types/foo` needs to be one as well.
This is especially apparent if the constraint on `foo` spans multiple major versions.
If we'd make `@types/foo` a direct dependency, users couldn't control which major version they get.
Package managers would pick the highest.
By moving `@types/foo` to peer dependencies, users can control which version of `foo` and  `@types/foo` they have.
    @eps1lon
    eps1lon committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9e34b45 View commit details
    Browse the repository at this point in the history

  2. feat!: move dtl to peerDeps 

    commit 2fa5eac
Author: Matan Borenkraout <matanbobi@gmail.com>
Date:   Wed Apr 24 11:06:27 2024 +0300

    fix formatting

commit 7a07982
Author: Matan Borenkraout <matanbobi@gmail.com>
Date:   Wed Apr 24 09:14:25 2024 +0300

    feat!: move dtl to peerDeps
    @eps1lon
    eps1lon committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c4b764e View commit details
    Browse the repository at this point in the history