Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types breaking changes #1274

Closed
wants to merge 2 commits into from

Conversation

Akallabet
Copy link

@Akallabet Akallabet commented Feb 2, 2024

What: fixed Link to issue

Why: reverting breaking changes with types

How: N/A

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

Copy link

codesandbox-ci bot commented Feb 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f406a8:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to confirm the issue first: #1275 (comment)

@eps1lon
Copy link
Member

eps1lon commented Feb 5, 2024

Underlying issue is rejected. Thank you for highlighting the necessary changes!

@eps1lon eps1lon closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types are breaking
2 participants