This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
WIP Profiling Report #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hook produce a profile report which can be loaded in the `Javascript Profiler` devtools tab. It's a POC, does not have proper flag yet, and is subject to change
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
gioragutt
force-pushed
the
giorag/profiling-report
branch
from
1c8bd24
to
f09d7bc
Compare
benjamingr
reviewed
Oct 11, 2020
| instrumentor: IAutomationFrameworkInstrumentor, | ||
| page: RootCausePage | ||
| ) { | ||
| if (isPlaywrightPage(page)) { |
There was a problem hiding this comment.
y? Is this not possible in playwright?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is above the HTML Viewer PR, and should not be merged before it.
First commit is a cleanup, to move all hooks into the
hooksfolder.Related to #54
Available reports:
profile.cpuprofile:Devtools->Menu->More Tools->JavaScript Profiler->Load.performanceTrace.json:Devtools->Performance->Load Profile...(upload icon)TIP: on mac, dotfiles are hidden by default. Use ⌘ + ⇧ + . to toggle viewing dotfiles in finder.
Another possible report we can generate is lighthouse report. It can be
html, to more easily integrate it into the client, and/orjsonto be able to extract data from it.