This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
Add conventional commits #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now instead of calling "git commit" you need to run "yarn commit" instead. | This will run the commitizen cli and let you format your commit messages for better changelogs for future versions | I also added a pre-commit hook to lint your commits in order to prevent direct calls to "git commit" that don't follow the convention closes testimio#8
on windows I get a lot of "Expected linebreaks to be 'LF' but found 'CRLF'" errors before I git push
|
Hey Shai |
|
Sure thing It didn't take long to do, so feel free to reject it if needed 😄 |
|
Hey, the CLA is live. Shai can you please sign it? (saying "I agree to the CLA" in a GitHub comment is sufficient for now assuming your GitHub account and email are linked) - It transfers |
|
"I agree to the CLA" 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #8
I've added
commitizen,conventional-changelogandcommitlint(with a commit husky hook) to make sure the future commits follow the convention.Plus added a fix for eslint on windows machines