feat: Implements placement options and license specifications #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damacus
changed the title
|
Hey @mfortin this looks pretty reasonable to me! Can you run Chefstyle over the codebase and re-push, please? |
|
@damacus Done |
damacus
approved these changes
Nov 27, 2023
3 tasks
damacus
added a commit
that referenced
this pull request
Nov 27, 2023
|
@mfortin apologies I turned on auto-merge, before we had protected the main branch. Can you repush the PR please? It looks like there is a problem in the code that the unit tests have picked up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements placement options and license specifications
Issues Resolved
#591
tenancy: dedicated may not be sufficient for all use cases. Adding options to set placement host resource group arn and license configurations may be required in some advanced use cases.
Type of Change
feat: Add placement options and License Specifications
Check List