Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Vectorized tess-point in Python #12

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

christinahedges
Copy link
Contributor

Hi @christopherburke, this is a first PR to make tess-point a faster tool that's easier to use in Python. This is absolutely a work in progress (WIP) and there's lots missing from this PR right now! At the moment there is functionality to go from Pixels -> RA/Dec, and not the other way around. I need to implement that!

This PR has big changes to the API, and so I incremented the major version number. I changed the package structure around to make it easier to maintain, and added the first test of a few.

I'll open this now, and we can talk here about how to move forward!

To Do

  • Add docstrings and comments
  • Implement star_in_fov, optics_fp, make_az_asym, mm_to_pix, radec2pix
  • Add functions tess_stars2px_reverse_function_entry and tess_stars2px_function_entry with deprecation warnings
  • Ensure command line functions work
  • Ensure WASM functionality is included

Copy link
Collaborator

@christopherburke christopherburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with merging the work in progress additions that are currently located in sub directories. Currently, setup.cfg and setup.py are deleted and I am unfamiliar with the pyproject.toml format as well as the purpose of the poetry.lock file.
Will your code work if keep setup.cfg and setup.py for now and remove poetry.lock and pyproject.toml files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants