Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Diplopia Solution #4211

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

woodjohndavid
Copy link

I previously created a pull request from my branch JDWDIPLOPIA. This solution, while better than without it as far as diplopia is concerned, was a limited solution.

I am now creating a pull request from my branch JDWDIPLOPIA2. I believe that this is a more complete solution to the diplopia issue.

@stweil
Copy link
Contributor

stweil commented Mar 13, 2024

I don't see a commit which changes the Tesseract code. Is something missing?

@woodjohndavid
Copy link
Author

OK thanks @stweil

This may leave you somewhat concerned about my code changes, but I can assure you that I am a competent developer. I just never use GitHub other than with Tesseract, hence incompetent in that regard.

Note by the way, similar to the other pull request I generated, there are some new configuration values that can only be set in code as it stands, but should be made into available settings. I have not yet figured out the mechanism for doing that. If the diplopia changes I am proposing turn out to be useful, hopefully someone else familiar with the settings approach could take care of that. These configuration values are:

  • bool kRemoveDiplopia - if true, enables diplopia removal functionality. If false, my changes have no effect
  • int kMaxDiplopiaGap - number of timesteps apart to be considered diplopia, default 2

@amitdo
Copy link
Collaborator

amitdo commented Mar 14, 2024

Apart from testing that this patch has a positive effect on the diplopia issue, people should test if there is no negative effect in other places, like dropping of correct characters.

src/lstm/recodebeam.cpp Show resolved Hide resolved
src/lstm/recodebeam.cpp Outdated Show resolved Hide resolved
@woodjohndavid
Copy link
Author

Please note that this change is likely not appropriate for those using Tesseract for natural language recognition using relevant dawgs. It is primarily intended for those (like myself) using Tesseract to scan technical data, looking for exact character by character recognition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants