Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose feature for shared stdxx on android #51

Merged
merged 1 commit into from Mar 21, 2024

Conversation

NiklasEi
Copy link
Contributor

The cpal feature seems to be needed to get bevy + kira to work on my android phone.

@tesselode
Copy link
Owner

Is this always going to be needed on Android, or only when using Kira with Bevy? If it's the former, can we just make this a platform-specific dependency?

@NiklasEi
Copy link
Contributor Author

I don't think it's always needed, so I would follow the way cpal and bevy expose this via a feature flag.

From the cpal readme:

Oboe can either use a shared or static runtime. The static runtime is used by default, but activating the oboe-shared-stdcxx feature makes it use the shared runtime, which requires libc++_shared.so from the Android NDK to be present during execution.

@NiklasEi
Copy link
Contributor Author

FYI: the same solution has been taken in rodio now: RustAudio/rodio#546

@tesselode tesselode merged commit c8ba4a9 into tesselode:main Mar 21, 2024
@tesselode
Copy link
Owner

ok fiiiine i'll merge it

(thank you for your investigation!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants