Update geocoder.ex to include Territories #3868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The address returned by the following link returns Territory instead of state so I have added state aliases to include this information: https://nominatim.openstreetmap.org/reverse?format=xml&lat=-35.1604&lon=149.1049&zoom=19&addressdetails=1
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Once this change is applied is it possible to update existing data? |
|
Thanks for your suggestion!
You can code a migration step which can add it for old data, not sure about the performance in this case tbh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address returned by the following link returns a territory in place of state so I have added state aliases to include this information:
https://nominatim.openstreetmap.org/reverse?format=xml&lat=-35.1604&lon=149.1049&zoom=19&addressdetails=1