Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drives.json: show drives with duration=0 but distance>=0 #3867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DrMichael
Copy link
Collaborator

For discussion.
I would like to show also drives, where a duration of 0 is stored, but the distance is not 0. Kind of infinite speed... :-)

I just added OR (duration_min = 0 AND distance >= 0) to the WHERE clause.

For discussion.
I would like to show also drives, where a duration of 0 is stored, but the distance is not 0. Kind of infinite speed... :-)
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit b6f26de
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/6628de295a1189000929c284
😎 Deploy Preview https://deploy-preview-3867--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Apr 24, 2024
@jlestel
Copy link
Contributor

jlestel commented Apr 26, 2024

Do these "0 trips" not risk distorting other stats based on the number of trips?

If so, documentation for cleaning up these trips would be usefull for me.

@DrMichael
Copy link
Collaborator Author

DrMichael commented Apr 27, 2024

Do these "0 trips" not risk distorting other stats based on the number of trips?

They are not completely zero, they have a distance. I ran into it working on the Statistics dashboard, which did show them, but Drives did not. Either we do this change or I adapt the Statistics dashboard.

If so, documentation for cleaning up these trips would be usefull for me.

I also realised some invalid drives and some charging processes (no end_date or no significant data). Maybe removing those could be added to the documentation...

@jlestel
Copy link
Contributor

jlestel commented Apr 27, 2024

Do these "0 trips" not risk distorting other stats based on the number of trips?

They are not completely zero, they have a distance. I ran into it working on the Statistics dashboard, which did show them, but Drives did not. Either we do this change or I adapt the Statistics dashboard.

If so, documentation for cleaning up these trips would be usefull for me.

I also realised some invalid drives and some charging processes (no end_date or no significant data). Maybe removing those could be added to the documentation...

Thank you for the clarification. I already fix incomplete with https://docs.teslamate.org/docs/maintenance/manually_fixing_data/ but maybe it’s another command to fix your invalid drives / charges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants