Closing all the plots that ARMI opens

[john-science]

What is the change?

This PR makes sure that matplotlib plots in ARMI are closed.

Why is the change being made?

Someone recently complained to me that during their recent ARMI Application runs, they were getting matplotlib warnings that they had more than 20 plots open at a time.

I believe this is the result of an old design idea that ARMI should traffic in figure objects, passing them around freely. Maybe it was a nice idea, we could discuss, but I think it leaves open the real possibility that plots aren't closed when they should be.

---

Checklist

• This PR has only one purpose or idea.
• Tests have been added/updated to verify any new/changed code.

• The code style follows good practices.
• The commit message(s) follow good practices.

• The release notes have been updated if necessary.
• The documentation is still up-to-date in the doc folder.
• The dependencies are still up-to-date in pyproject.toml.

[john-science]

I think a lot of ARMI PRs are failing right now because the unit tests aren't cleaning up after themselves.

In particular, after all the tests are run, a file named armiRun.h5 appears to be left in the base dir of the working area.

This should be remedied.

[opotowsky]

I think a lot of ARMI PRs are failing right now because the unit tests aren't cleaning up after themselves.

In particular, after all the tests are run, a file named armiRun.h5 appears to be left in the base dir of the working area.

This should be remedied.

Interesting that it looks like it's only happening on windows and not linux

[john-science]

So, matplotlib released a new version to PyPI.org today. This removed (or changed?) the old color map logic we are using:

armi/armi/utils/reportPlotting.py

Line 732 in 872e2da

colormap = cm.get_cmap("jet")

You will see get_cmap() in matplotlib==3.7.5, but not in matplotlib==3.8.4.

[onufer]

please Delete this one. it cant close with plotBlockDepthMap

[opotowsky]

ope! @john-science I guess we didn't test this internally