Change the properties of Doppler constant params #1659
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Reactivity coefficient parameters for the Doppler constant were configured with the
ParamLocation.AVERAGE
location attribute. These parameters are actuallyParamLocation.VOLUME_INTEGRATED
, so they are being changed.Why is the change being made?
The Doppler constant for a given block is proportional to the size of the block. If two blocks were to be combined into one, the combined block Doppler constant would be the sum of the two smaller blocks:
This is achieved with
ParamLocation.VOLUME_INTEGRATED
, notPararmLocation.AVERAGE
.The Doppler constant is directly related to the Doppler coefficient in units of pcm/K; the coefficients were already labeled as
ParamLocation.VOLUME_INTEGRATED
.Checklist
doc
folder.pyproject.toml
.