New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit XS Settings when creating a new XS ID #1653
base: main
Are you sure you want to change the base?
Conversation
When new XS Types are created by the cross section group manager, initialize them with the same settings as the original XS ID from which they were created.
Hi @mgjarrett - I might be misremembering but I think that we need to handle the case where the original XS settings are a link to an external cross section file or files. In that case we might need to default to 0D. Maybe I am misrememberinf why I implemented it this way. |
We shouldn't be trying to make a modified representative block based on a XS group that uses pregenerated cross sections. There is a warning logged in that situation: armi/armi/physics/neutronics/crossSectionGroupManager.py Lines 1255 to 1261 in 6163e94
No error is thrown, and you could even end up not getting the warning, depending on the arguments passed into |
What is the change?
When the cross section group manager creates a new XS ID that is based on a previous XS ID within
CrossSectionGroupManager._getModifiedReprBlocks()
, the new settings will now be inherited from the settings for the original XS group.Why is the change being made?
Previously, a new XS ID would just be initialized with default cross section settings. Typically, when a user is creating a modified representative block with a new XS ID, they would want to keep the cross section settings from the original XS group.
Checklist
doc/release/0.X.rst
) are up-to-date with any important changes.doc
folder.pyproject.toml
.