Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verifyExpansion with derivedShape solvent #1647

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AidanMcDonald
Copy link

@AidanMcDonald AidanMcDonald commented Feb 14, 2024

What is the change?

blockConverter._verifyExpansion() was throwing an error when the solvent was a derivedShape Component because isEncapsulatedBy requires the "other" component to have an "od" Parameter. I believe this check doesn't make sense for a derivedShape Component, so I added a simple check to skip the isEncapsulatedBy call in this case.

Why is the change being made?

This change is necessary for using the openmc plugin. Openmc cannot handle helix components so the openmc input writer uses MultipleComponentMerger, in which this bug arose.


Checklist

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2024

CLA assistant check
All committers have signed the CLA.

@john-science john-science self-requested a review March 10, 2024 18:56
@john-science john-science added the bug Something is wrong: Highest Priority label Mar 10, 2024
@@ -28,6 +28,7 @@ coverage.lcov
coverage_results.*
htmlcov/
monkeytype.*
armicontrib-openmc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could just replace this line with:

armicontrib-*

As a little future-proofing.

@john-science
Copy link
Member

Adding a unit test to prove the idea would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants