Fix: Fix issue with replica state key and random IDs (#141)

terraform-google-modules · Aug 26, 2020 · 71b51fd · 71b51fd
1 parent 76244bd
commit 71b51fd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/docs/upgrading_to_sql_db_4.0.0.md b/docs/upgrading_to_sql_db_4.0.0.md
@@ -42,6 +42,9 @@ The new `read_replicas` variable is used to manage all replica configuration. In
 
 - You must have `read_replica_size` objects inside `read_replicas`
 - You must use the full `zone` id which includes the region e.g. `europe-west1-c` instead of `c`
+- You must not have used `random_instance_name`
+
+**Important:** If you have enabled `random_instance_name` then you will need to manually migrate state because the migration script and module does not include the random string as part of the replica state key.
 
 ```diff
  module "test" {

diff --git a/modules/mysql/read_replica.tf b/modules/mysql/read_replica.tf
@@ -16,7 +16,7 @@
 
 locals {
   replicas = {
-    for x in var.read_replicas : "${local.master_instance_name}-replica${var.read_replica_name_suffix}${x.name}" => x
+    for x in var.read_replicas : "${var.name}-replica${var.read_replica_name_suffix}${x.name}" => x
   }
 }
 

diff --git a/modules/postgresql/read_replica.tf b/modules/postgresql/read_replica.tf
@@ -16,7 +16,7 @@
 
 locals {
   replicas = {
-    for x in var.read_replicas : "${local.master_instance_name}-replica${var.read_replica_name_suffix}${x.name}" => x
+    for x in var.read_replicas : "${var.name}-replica${var.read_replica_name_suffix}${x.name}" => x
   }
 }