Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for public beta upgrade variant #553

Merged

Conversation

tommyknows
Copy link
Contributor

@tommyknows tommyknows commented Jun 9, 2020

As asked for in #546 (@morgante), this adds an example for the beta-public-update-variant module.

I copied the node_pool_update_variant_beta and removed the variables that do not exist.
Not quite sure if this works & is the way to go to be honest :-)

@tommyknows tommyknows requested review from bharathkkb, Jberlinsky and a team as code owners June 9, 2020 08:53
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you please run terraform fmt and get linters running?

@morgante morgante force-pushed the master branch 2 times, most recently from 4beaeb7 to 6069ece Compare July 8, 2020 06:42
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@comment-bot-dev
Copy link

comment-bot-dev commented Jan 6, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

Signed-off-by: Ramon Rüttimann <ramon@nine.ch>
@tommyknows
Copy link
Contributor Author

Sorry, completely lost track of this. I've ran the linters and everything, pipeline is passing.

@morgante morgante merged commit d473b14 into terraform-google-modules:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants