Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make auto_provisioning_defaults a non-beta feature #1077

Merged
merged 1 commit into from Nov 30, 2021
Merged

feat: Make auto_provisioning_defaults a non-beta feature #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion autogen/main/cluster.tf.tmpl
View file
Open in desktop
Expand Up @@ -86,15 +86,18 @@ resource "google_container_cluster" "primary" {

cluster_autoscaling {
enabled = var.cluster_autoscaling.enabled
{% if beta_cluster %}
dynamic "auto_provisioning_defaults" {
for_each = var.cluster_autoscaling.enabled ? [1] : []

content {
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
{% if beta_cluster %}
min_cpu_platform = lookup(var.node_pools[0], "min_cpu_platform", "")
{% endif %}
}
}
{% if beta_cluster %}
autoscaling_profile = var.cluster_autoscaling.autoscaling_profile != null ? var.cluster_autoscaling.autoscaling_profile : "BALANCED"
{% endif %}
dynamic "resource_limits" {
Expand Down
8 changes: 8 additions & 0 deletions cluster.tf
View file
Open in desktop
Expand Up @@ -58,6 +58,14 @@ resource "google_container_cluster" "primary" {

cluster_autoscaling {
enabled = var.cluster_autoscaling.enabled
dynamic "auto_provisioning_defaults" {
for_each = var.cluster_autoscaling.enabled ? [1] : []

content {
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
}
}
dynamic "resource_limits" {
for_each = local.autoscaling_resource_limits
content {
Expand Down
5 changes: 3 additions & 2 deletions modules/beta-private-cluster-update-variant/cluster.tf
View file
Open in desktop
Expand Up @@ -77,8 +77,9 @@ resource "google_container_cluster" "primary" {
for_each = var.cluster_autoscaling.enabled ? [1] : []

content {
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
min_cpu_platform = lookup(var.node_pools[0], "min_cpu_platform", "")
}
}
autoscaling_profile = var.cluster_autoscaling.autoscaling_profile != null ? var.cluster_autoscaling.autoscaling_profile : "BALANCED"
Expand Down
5 changes: 3 additions & 2 deletions modules/beta-private-cluster/cluster.tf
View file
Open in desktop
Expand Up @@ -77,8 +77,9 @@ resource "google_container_cluster" "primary" {
for_each = var.cluster_autoscaling.enabled ? [1] : []

content {
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
min_cpu_platform = lookup(var.node_pools[0], "min_cpu_platform", "")
}
}
autoscaling_profile = var.cluster_autoscaling.autoscaling_profile != null ? var.cluster_autoscaling.autoscaling_profile : "BALANCED"
Expand Down
5 changes: 3 additions & 2 deletions modules/beta-public-cluster-update-variant/cluster.tf
View file
Open in desktop
Expand Up @@ -77,8 +77,9 @@ resource "google_container_cluster" "primary" {
for_each = var.cluster_autoscaling.enabled ? [1] : []

content {
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
min_cpu_platform = lookup(var.node_pools[0], "min_cpu_platform", "")
}
}
autoscaling_profile = var.cluster_autoscaling.autoscaling_profile != null ? var.cluster_autoscaling.autoscaling_profile : "BALANCED"
Expand Down
5 changes: 3 additions & 2 deletions modules/beta-public-cluster/cluster.tf
View file
Open in desktop
Expand Up @@ -77,8 +77,9 @@ resource "google_container_cluster" "primary" {
for_each = var.cluster_autoscaling.enabled ? [1] : []

content {
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
min_cpu_platform = lookup(var.node_pools[0], "min_cpu_platform", "")
}
}
autoscaling_profile = var.cluster_autoscaling.autoscaling_profile != null ? var.cluster_autoscaling.autoscaling_profile : "BALANCED"
Expand Down
8 changes: 8 additions & 0 deletions modules/private-cluster-update-variant/cluster.tf
View file
Open in desktop
Expand Up @@ -58,6 +58,14 @@ resource "google_container_cluster" "primary" {

cluster_autoscaling {
enabled = var.cluster_autoscaling.enabled
dynamic "auto_provisioning_defaults" {
for_each = var.cluster_autoscaling.enabled ? [1] : []

content {
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
}
}
dynamic "resource_limits" {
for_each = local.autoscaling_resource_limits
content {
Expand Down
8 changes: 8 additions & 0 deletions modules/private-cluster/cluster.tf
View file
Open in desktop
Expand Up @@ -58,6 +58,14 @@ resource "google_container_cluster" "primary" {

cluster_autoscaling {
enabled = var.cluster_autoscaling.enabled
dynamic "auto_provisioning_defaults" {
for_each = var.cluster_autoscaling.enabled ? [1] : []

content {
service_account = local.service_account
oauth_scopes = local.node_pools_oauth_scopes["all"]
}
}
dynamic "resource_limits" {
for_each = local.autoscaling_resource_limits
content {
Expand Down