Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bash scripts more portable #756

Merged
merged 1 commit into from Dec 4, 2020
Merged

Make bash scripts more portable #756

merged 1 commit into from Dec 4, 2020

Conversation

johnae
Copy link
Contributor

@johnae johnae commented Dec 4, 2020 •
edited

On my distro these scripts won't work since there is no /bin/bash, if instead we use /usr/bin/env bash for shebang these would work in more places.

Thanks for a great tf module!

@johnae johnae requested review from bharathkkb, Jberlinsky and a team as code owners December 4, 2020 15:54
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

morgante
morgante approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@morgante morgante merged commit 24d6af6 into terraform-google-modules:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnae @comment-bot-dev @morgante