Skip to content

Commit

Permalink
fix: Make bash scripts more portable by referencing /usr/bin/env (#756
Browse files Browse the repository at this point in the history 
)
  • Loading branch information
@johnae
johnae committed Dec 4, 2020
1 parent eb95de9 commit 24d6af6
Show file tree
Hide file tree
Showing 31 changed files with 34 additions and 31 deletions.
2 changes: 1 addition & 1 deletion autogen/main/scripts/delete-default-resource.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion autogen/main/scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion autogen/main/scripts/wait-for-cluster.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
3 changes: 2 additions & 1 deletion examples/node_pool/data/shutdown-script.sh
View file
@@ -1,4 +1,5 @@
#!/bin/bash -e
#!/usr/bin/env bash
set -e

# Copyright 2018 Google LLC
#
Expand Down
3 changes: 2 additions & 1 deletion examples/node_pool_update_variant/data/shutdown-script.sh
View file
@@ -1,4 +1,5 @@
#!/bin/bash -e
#!/usr/bin/env bash
set -e

# Copyright 2018 Google LLC
#
Expand Down
3 changes: 2 additions & 1 deletion examples/node_pool_update_variant_beta/data/shutdown-script.sh
View file
@@ -1,4 +1,5 @@
#!/bin/bash -e
#!/usr/bin/env bash
set -e

# Copyright 2018 Google LLC
#
Expand Down
2 changes: 1 addition & 1 deletion modules/asm/scripts/install_asm.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster-update-variant/scripts/delete-default-resource.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster-update-variant/scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster-update-variant/scripts/wait-for-cluster.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster/scripts/delete-default-resource.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster/scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-private-cluster/scripts/wait-for-cluster.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-public-cluster-update-variant/scripts/delete-default-resource.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-public-cluster-update-variant/scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-public-cluster-update-variant/scripts/wait-for-cluster.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-public-cluster/scripts/delete-default-resource.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-public-cluster/scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/beta-public-cluster/scripts/wait-for-cluster.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/hub/scripts/gke_hub_registration.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/k8s-operator-crd-support/scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/k8s-operator-crd-support/scripts/wait_for_gatekeeper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster-update-variant/scripts/delete-default-resource.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster-update-variant/scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster-update-variant/scripts/wait-for-cluster.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster/scripts/delete-default-resource.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster/scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion modules/private-cluster/scripts/wait-for-cluster.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion scripts/delete-default-resource.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion scripts/kubectl_wrapper.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 1 addition & 1 deletion scripts/wait-for-cluster.sh
View file
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
# Copyright 2019 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down

3 comments on commit 24d6af6

@thiattvpt
Copy link

@thiattvpt thiattvpt commented on 24d6af6 Jan 9, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @johnae, I wanted to ask a very amateur question about this commit. You may not even be able to help me. However I am trying to learn and understand an issue I am having.
I am running a GCP Build Job that is using the hashicorp/terraform docker images. In turn I have TF module to build GCP Kubernetes that runs inside that hashicorp/terraform image.

When the apply or destroy function runs. It attempts to run the "wait-for-cluster.sh" script above. However the Hashicorp/terraform container image spits out an error saying

Error: Error running command 'PATH=/google-cloud-sdk/bin:$PATH
.terraform/modules/kubernetes.kubernetes/scripts/wait-for-cluster.sh xxxxxxxxx xxxxx europe-west1
': exit status 127. Output: env: can't execute 'bash': No such file or directory

I am trying to work out how to overcome this issue using the hashicorp/terraform images and I stumbled upon this commit of yours and while the hashicorp/terraform image and the terraform-google-modules/terraform-google-kubernetes-engine are independent of either other I thought you might be able to assist me understand how I might fix this issue.

Would be interested on any opinions you might have. Thanks.

@johnae
Copy link
Contributor Author

@johnae johnae commented on 24d6af6 Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your issue is likely that the terraform image doesn't include bash. I don't know for sure but that's my suspicion anyway.

@thiattvpt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnae cheers. Thats the suspicion I am working off at the moment. I am trying to replicate the whole process locally first. Thanks for validating my thought process.

Please sign in to comment.