-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add website segmentation #297
base: master
Are you sure you want to change the base?
feat!: add website segmentation #297
Conversation
Review, please? |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bruno561
@@ -243,9 +243,12 @@ variable "cors" { | |||
} | |||
|
|||
variable "website" { | |||
type = map(any) | |||
type = map(object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC now we will specify a map of bucket-names to configuration object? Could we provide a special key like all
to ease the transition for users who want to use historical behavior? It would also be good to capture this in an upgrade guide https://github.com/terraform-google-modules/terraform-google-cloud-storage/tree/master/docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharathkkb If I'm not mistaken, if we use all
it could break depending on the configuration the user enters.
Adding the ability to segment website configurations by buckets
#294