Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass answers to validator function #382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DesignByOnyx
Copy link

@DesignByOnyx DesignByOnyx commented Jan 7, 2023

This closes #273

I don't consider this done yet, but I wanted to go ahead and take a stab at this and get some feedback. Tasks still remaining:

This is not my favortie implementation, but it's the best I could come up with short of a refactor. The crux of the problems is we need to pass the answers to all elements as they are constructed. In an ideal world the question and answers would be passed as two separate arguments to the element constructors. I'm glad to make that change, though it will touch a lot more files and lines of code.

@DesignByOnyx
Copy link
Author

I needed this again today and prefer not to use my fork. I have time, availability, and eagerness to implement this. I will write tests and ensure there are no breaking changes. Any feedback from the team would be great... even if it's in the form of "we don't have time to review this, and it probably wont get merged" would help. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: validate function should provide values as 2nd argument
1 participant