This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
Fixing snapshot zoom issues on "plus" devices in Zoom-mode #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
thx for this awesome lib, but I think I found a problem:
On Plus-devices the center-panel that will transition to the side will be rendered too big at the end of the transition if the app is running "zoomed".
Why? The UIScreen.main.snappshotView(...) returns a UIView that will match the actual UIScreen, not the "zoomed" one, so we need to set the frame accordingly.
I have tested this in my app and it seems to work, but I haven't checked all possibilities. If you think there might be a problem in a certain config let me know and I check it out.