Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle loading of configured and non-configured contexts with the same name #4224

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Dakostu
Copy link
Member

@Dakostu Dakostu commented May 15, 2024

This change adds order to the chaos of loading contexts.
Configured contexts will be loaded first, and non-configured contexts that happen to share the same name will be renamed to avoid non-deterministic loading conflicts.

@Dakostu Dakostu added the maintenance Tasks for keeping up the infrastructure label May 15, 2024
@Dakostu Dakostu requested a review from a team May 15, 2024 22:07
@Dakostu Dakostu force-pushed the topic/fix-configured-context-precedence branch from 341015d to 39f3120 Compare May 15, 2024 22:12
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Dakostu Dakostu force-pushed the topic/fix-configured-context-precedence branch 3 times, most recently from 5bde192 to 1519d4d Compare May 24, 2024 12:55
@Dakostu Dakostu force-pushed the topic/fix-configured-context-precedence branch 3 times, most recently from 8df913f to 73f6b8e Compare May 28, 2024 13:37
@Dakostu Dakostu changed the title Update the submodule pointer to include configured context precedence Handle loading of configured and non-configured contexts with the same name May 29, 2024
contrib/tenzir-plugins Show resolved Hide resolved
@Dakostu Dakostu force-pushed the topic/fix-configured-context-precedence branch from 73f6b8e to be31ec0 Compare June 4, 2024 10:13
@Dakostu Dakostu merged commit 3945f44 into main Jun 4, 2024
56 checks passed
@Dakostu Dakostu deleted the topic/fix-configured-context-precedence branch June 4, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
3 participants