Relax transform_columns
#4215
Merged
Relax transform_columns
#4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
bug
dominiklohmann
force-pushed
the
topic/relax-transform-columns
branch
from
7c035c0
to
4b0c04d
Compare
mavam
approved these changes
May 13, 2024
The function now gracefully handles slices with no columns and is no longer noexcept so that misuse only crashes one operator instead of the entire process.
dominiklohmann
force-pushed
the
topic/relax-transform-columns
branch
from
4b0c04d
to
776c49d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function now gracefully handles slices with no columns and is no longer noexcept so that misuse only crashes one operator instead of the entire process.