Change the syntax of the slice operator
#4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
operator
dominiklohmann
force-pushed
the
topic/slice-syntax
branch
from
5e5a0bc
to
cb5b9b6
Compare
This changes the `slice` operator to use a more familiar syntax for slicing events: `<begin>:<end>`, `<begin>:`, or `:<end>`.
dominiklohmann
force-pushed
the
topic/slice-syntax
branch
from
cb5b9b6
to
5b5ffc8
Compare
jachris
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
sliceoperator to use a more familiar syntax for slicing events:<begin>:<end>,<begin>:, or:<end>.This makes room for adding strides to the operator in the famililar Python syntax.