Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV/XSV format printing the header once for each batch #4195

Merged
merged 3 commits into from
May 8, 2024

Conversation

jachris
Copy link
Contributor

@jachris jachris commented May 8, 2024

The XSV format printed the header once for each batch. This PR makes it so that the header is printed only once.

The actual diff can be seen in the second commit.

@jachris jachris force-pushed the topic/fix-xsv-batch-header-printing branch from 6bdc7c2 to 28ae64d Compare May 8, 2024 10:06
@jachris jachris added bug Incorrect behavior format Parser and printer labels May 8, 2024
@jachris jachris force-pushed the topic/fix-xsv-batch-header-printing branch from 28ae64d to 2dc5b4c Compare May 8, 2024 10:08
@jachris jachris marked this pull request as ready for review May 8, 2024 10:08
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a changelog entry, otherwise LGTM.

@jachris jachris force-pushed the topic/fix-xsv-batch-header-printing branch from c8eb508 to 0e212ea Compare May 8, 2024 12:11
@jachris jachris enabled auto-merge May 8, 2024 12:11
@jachris jachris merged commit 0a0b668 into main May 8, 2024
51 checks passed
@jachris jachris deleted the topic/fix-xsv-batch-header-printing branch May 8, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior format Parser and printer
Projects
None yet
2 participants