Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cron operator #4192

Merged
merged 18 commits into from
May 9, 2024
Merged

Add cron operator #4192

merged 18 commits into from
May 9, 2024

Conversation

IyeOnline
Copy link
Contributor

Adds a cron operator that does scheduled execution analogous to the every operator.

Fixes https://github.com/tenzir/issues/issues/1684

@IyeOnline IyeOnline added feature New functionality operator Source, transformation, and sink labels May 7, 2024
@jachris jachris changed the title Add 'cron' operator Add cron operator May 8, 2024
@jachris jachris self-requested a review May 8, 2024 10:17
Copy link
Contributor

@jachris jachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides one minor functional issue, this works great. Thank you! 🚀

And sorry for the flood of comments. Most of them are nitpicks or about things that you'll just get used to very soon when it comes to this code base.

changelog/next/features/4192--cron-operator-modifier.md Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Show resolved Hide resolved
Copy link
Contributor

@jachris jachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. This works as expected now and can be merged once the remaining open conversations are addressed 👍

libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/operators/every_cron.cpp Outdated Show resolved Hide resolved
web/docs/language/operator-modifiers.md Outdated Show resolved Hide resolved
web/docs/language/operator-modifiers.md Outdated Show resolved Hide resolved
@IyeOnline IyeOnline enabled auto-merge May 9, 2024 13:33
@IyeOnline IyeOnline merged commit 71bcc5d into main May 9, 2024
51 checks passed
@IyeOnline IyeOnline deleted the topic/scheduled-execution branch May 9, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality operator Source, transformation, and sink
Projects
None yet
2 participants