Make python venv creation independent from the user #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did quite a bit of testing on this and unfortunately the change as proposed so far does not work. The problem is that semaphore creation is subject to the processes A complete fix should still be possible by wrapping all the venv creation steps in an extra python subprocess (which would be single threaded) and use that to manage the inter process synchronization. This would have the nice side effect of securing the sync against SIGKILLs, SEGFAULTS, and the like. |
|
There's also the option of creating separate cache directories per user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A permission error caused python operator to fail when it was previously used by another system user with the same set of requirements.