Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new loading mechanism for GeoIP context #4158

Merged
merged 29 commits into from May 10, 2024

Conversation

balavinaithirthan
Copy link
Contributor

@balavinaithirthan balavinaithirthan commented Apr 25, 2024

  1. We added an additional loader to the GeoIP plugin to allow for users to create an empty context, load data in later, and replace contexts through data loads. The loader allows for the original V1 loader to still work because it loads the V1 context into memory and on save converts it to a V2 context. The context save context_name should not be used alone because an implicit writing sink is added to the end; instead it should continue being used to pipe data into context load.

Questions:

  1. Is it possible to rebase onto main with the tensor-plugins submodule conflict?

@mavam mavam changed the title Add new loading mechanism for Geo Ip context Add new loading mechanism for GeoIP context Apr 25, 2024
@balavinaithirthan balavinaithirthan added feature New functionality connector Loader and saver labels Apr 25, 2024
@balavinaithirthan balavinaithirthan marked this pull request as ready for review April 26, 2024 15:01
@balavinaithirthan balavinaithirthan marked this pull request as draft April 26, 2024 15:29
libtenzir/builtins/contexts/geoip.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/contexts/geoip.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/contexts/geoip.cpp Show resolved Hide resolved
libtenzir/builtins/contexts/geoip.cpp Show resolved Hide resolved
libtenzir/builtins/contexts/geoip.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/contexts/geoip.cpp Outdated Show resolved Hide resolved
libtenzir/builtins/contexts/geoip.cpp Outdated Show resolved Hide resolved
@balavinaithirthan balavinaithirthan marked this pull request as ready for review May 8, 2024 21:29
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this! I think this is a very solid improvement to the geoip context usability.

@balavinaithirthan balavinaithirthan merged commit 83ba5fc into main May 10, 2024
51 checks passed
@balavinaithirthan balavinaithirthan deleted the topic/newGeoIpInputType branch May 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector Loader and saver feature New functionality
Projects
None yet
4 participants