Minor cleanups and simplifications #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
approved these changes
Apr 5, 2024
tobim
force-pushed
the
topic/minor-fixes
branch
from
2ee9a07
to
9fde516
Compare
tobim
force-pushed
the
topic/minor-fixes
branch
from
9fde516
to
027ceb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a bunch of minor improvements that I found during other recent work. They are not directly related or necessary for any planned work, but it is still valuable to use opportunities for cleanup and simplifications to make our lives a little easier in the long run.
To the reviewer:
CI should catch possible errors, please don't spend more than 2 minutes on this. If you find an issue with one of the changes I will just drop that.