Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exporter metrics (again) #3652

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fix exporter metrics (again) #3652

merged 2 commits into from
Nov 17, 2023

Conversation

dominiklohmann
Copy link
Member

No description provided.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Nov 17, 2023
@dominiklohmann dominiklohmann force-pushed the topic/fix-exporter-metrics-part-3 branch 2 times, most recently from ef18bb5 to 2db7ba8 Compare November 17, 2023 08:37
@dominiklohmann dominiklohmann force-pushed the topic/fix-exporter-metrics-part-3 branch from 2db7ba8 to f43815f Compare November 17, 2023 08:43
tobim
tobim approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should finally be watertight.

@dominiklohmann dominiklohmann merged commit c5e9070 into main Nov 17, 2023
42 of 44 checks passed
@dominiklohmann dominiklohmann deleted the topic/fix-exporter-metrics-part-3 branch November 17, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
2 participants
@dominiklohmann @tobim