Fix program startup of the static binary #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent addition of the s3 connector causes the linker to add symbols from the AWS crypto abstraction layer library. This lib uses the `dlopen` and `dlclose` functions even when built as a static library - which is possible. What's more, the return value of those functions is asserted, causing the tenzir executables to abort during initialization. The good news is that this can be worked around by disabling the problematic assert. For that we pull a patch that does exactly that from an open upstream pull request.
dit7ya
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of the s3 connector causes the linker to add symbols from the AWS crypto abstraction layer library. This lib uses the
dlopenanddlclosefunctions even when built as a static library - which is possible. What's more, the return value of those functions is asserted, causing the tenzir executables to abort during initialization.The good news is that this can be worked around by disabling the problematic assert. For that we pull a patch that does exactly that from an open upstream pull request.
Fixes https://github.com/tenzir/issues/issues/885.